Ubuntu
numactl package

Fix numa_node_to_cpus patch

Bug #1535494 reported by Serge Hallyn
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
numactl (Ubuntu)
Fix Released
Medium
Unassigned
Trusty
Fix Released
Undecided
Unassigned
Vivid
Won't Fix
Undecided
Unassigned
Wily
Fix Released
Undecided
Unassigned

Bug Description

=============================================
SRU Justification
same justification as for bug 1358835. It would
be great to have the same test cases run as in that
bug.

The fix uploaded in that bug is wrong, in particular the diff between the two patches includes:

-+ if (f) {
++ if (numa_bitmask_isbitset(numa_nodes_ptr, node)) {

"if (f)" is a bogus test, f is simply an opened file.
=============================================

In bug 1358835 we applied a fix to supress a warning. The patch is different
from upstream (and appears wrong).

In particular,

+ if (numa_bitmask_isbitset(numa_nodes_ptr, node)) {

becomes

+ if (f) {

Switch to a straight cherrypick of the upstream patch.

See original description
Serge Hallyn (serge-hallyn)
Changed in numactl (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package numactl - 2.0.10-1ubuntu7

---------------
numactl (2.0.10-1ubuntu7) xenial; urgency=medium

  * Switch libnuma-ppc64el-cpu-number-not-contiguous.patch to the
    cherrypicked upstream version. (LP: #1535494)

 -- Serge Hallyn <email address hidden> Mon, 18 Jan 2016 17:21:10 -0800

Changed in numactl (Ubuntu):
status: Triaged → Fix Released
Serge Hallyn (serge-hallyn)
description: updated
description: updated
Brian Murray (brian-murray)
Changed in numactl (Ubuntu Vivid):
status: New → Won't Fix
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Serge, or anyone else affected,

Accepted numactl into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/numactl/2.0.10-1ubuntu6.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in numactl (Ubuntu Wily):
status: New → Fix Committed
tags: added: verification-needed
Changed in numactl (Ubuntu Trusty):
status: New → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Serge, or anyone else affected,

Accepted numactl into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/numactl/2.0.9~rc5-1ubuntu3.14.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Test on a amd64 qemu vm with 82 cpus (though no numa config).

Wily and trusty both seemed good.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package numactl - 2.0.9~rc5-1ubuntu3.14.04.2

---------------
numactl (2.0.9~rc5-1ubuntu3.14.04.2) trusty-proposed; urgency=medium

  * Switch libnuma-ppc64el-cpu-number-not-contiguous.patch to the
    cherrypicked upstream version. (LP: #1535494)

 -- Serge Hallyn <email address hidden> Thu, 18 Feb 2016 11:47:00 -0800

Changed in numactl (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for numactl has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package numactl - 2.0.10-1ubuntu6.1

---------------
numactl (2.0.10-1ubuntu6.1) wily-proposed; urgency=medium

  * Switch libnuma-ppc64el-cpu-number-not-contiguous.patch to the
    cherrypicked upstream version. (LP: #1535494)

 -- Serge Hallyn <email address hidden> Mon, 18 Jan 2016 17:21:10 -0800

Changed in numactl (Ubuntu Wily):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.