OpenStack Shared File Systems Service (Manila)

Update hacking version in Manila to hacking<0.11,>=0.10.0

Bug #1530719 reported by Goutham Pacha Ravi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
David Sariel

Bug Description

The version of hacking in test-requrements.txt is beyond
the stated in global requirements. Cinder, Nova, Neutron,
Glance are using the hacking version according to global
requirements.

Update the version of hacking and fix several pep8 issues
due to the hacking version propagation.

The list of issues:
    - W292 No newline at end of file
    - H105 Don't use author tags
    - H238 Old style class declaration, use new style (inherit from `object`)
    - H501 Do not use self.__dict__ for string formatting

Revision history for this message
David Sariel (dsariel) wrote :

Fix committed: https://review.openstack.org/#/c/262781/

Changed in manila:
assignee: nobody → David (dsariel)
status: New → Fix Committed
David Sariel (dsariel)
Changed in manila:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/262781
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4a61faa065dc445bb32cff1a464d2e22e84e5427
Submitter: Jenkins
Branch: master

commit 4a61faa065dc445bb32cff1a464d2e22e84e5427
Author: David Sariel <email address hidden>
Date: Sun Feb 14 14:55:46 2016 +0200

    Removed ignored checks from tox.ini and fixed pep8 issues

    Due to the hacking version update several pep8 checks where ignored
    in the flakes8 section of the tox.ini. Removed ignored checks and fixed
    appropriate pep8 issues.

    The list of fixed issues:
        - H105 Don't use author tags
        - H238 Old style class declaration, use new style (inherit from `object`)
        - H501 Do not use self.__dict__ for string formatting

    Closes-Bug: 1530719
    Change-Id: I890ba4c54b0da10060767620ff5ff7e480d79a9c

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/manila 2.0.0.0b3

This issue was fixed in the openstack/manila 2.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.