Importing Songbeamer songs using latin1 encoding doesn't get decoded correctly
Bug #1530597 reported by
Simon Hanna
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Low
|
Tomas Groth | ||
| 2.4 |
Fix Released
|
Low
|
Tomas Groth | ||
Bug Description
When exporting Songbeamer songs from Windows and then importing them on Linux,
the encoding of the songs is latin1. During the import OpenLP seems to assume they are UTF-8.
This works for "normal" characters but breaks for german "Umlaute"
Related branches
lp:~tomasgroth/openlp/song-import-fixes25
- Tim Bentley: Approve
-
Diff: 311 lines (+130/-29)9 files modifiedopenlp/plugins/songs/lib/__init__.py (+2/-2)
openlp/plugins/songs/lib/importers/easyslides.py (+12/-12)
openlp/plugins/songs/lib/importers/songbeamer.py (+9/-6)
openlp/plugins/songs/lib/importers/videopsalm.py (+4/-2)
tests/functional/openlp_plugins/songs/test_easyslidesimport.py (+2/-0)
tests/resources/easyslidessongs/Amazing Grace.json (+6/-6)
tests/resources/easyslidessongs/Export_2017-01-12_BB.json (+44/-0)
tests/resources/easyslidessongs/Export_2017-01-12_BB.xml (+50/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold.json (+1/-1)
lp:~tomasgroth/openlp/song-import-fixes24
- Tim Bentley: Approve
-
Diff: 407 lines (+174/-29)12 files modifiedopenlp/core/__init__.py (+38/-2)
openlp/core/lib/treewidgetwithdnd.py (+6/-1)
openlp/core/ui/slidecontroller.py (+2/-0)
openlp/plugins/songs/lib/__init__.py (+2/-2)
openlp/plugins/songs/lib/importers/easyslides.py (+12/-12)
openlp/plugins/songs/lib/importers/songbeamer.py (+7/-3)
openlp/plugins/songs/lib/importers/videopsalm.py (+4/-2)
tests/functional/openlp_plugins/songs/test_easyslidesimport.py (+2/-0)
tests/resources/easyslidessongs/Amazing Grace.json (+6/-6)
tests/resources/easyslidessongs/Export_2017-01-12_BB.json (+44/-0)
tests/resources/easyslidessongs/Export_2017-01-12_BB.xml (+50/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold.json (+1/-1)
Revision history for this message
| Simon Hanna (thelinuxguy) wrote | #1 |
Revision history for this message
| Simon Hanna (thelinuxguy) wrote | #2 |
Revision history for this message
| Tomas Groth (tomasgroth) wrote | #3 |
Revision history for this message
| Simon Hanna (thelinuxguy) wrote | #4 |
Revision history for this message
| Tomas Groth (tomasgroth) wrote | #5 |
| Changed in openlp: | |
| assignee: | nobody → Tomas Groth (tomasgroth) |
| importance: | Undecided → Low |
| status: | New → In Progress |
| Changed in openlp: | |
| milestone: | none → 2.5.1 |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
It looks like chardet is the culprit that detects the file being MacCyrillic