wrong flake8 exception

Bug #1529092 reported by HouMing Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
HouMing Wang

Bug Description

In the manila/tox.ini

[flake8]
# Following checks are ignored on purpose:
#
# H904 wrap long lines in parentheses instead of a backslash
# reason: removed in hacking (https://review.openstack.org/#/c/101701/)
ignore = H904
builtins = _
exclude = .venv,.tox,dist,doc,openstack,*egg

all 'openstack' directories are excluded. This rule is intended to exclude manila/openstack/common code check, but this rule is wrong because it also exclude checks against manila/api/openstack and manila/tests/api/openstack. We should fix it

The following are detail violations:

./manila/api/openstack/__init__.py:27:1: F401 'utils' imported but unused
./manila/api/openstack/__init__.py:61:1: H404 multi line docstring should start without a leading new line
./manila/api/openstack/__init__.py:61:1: H405 multi line docstring summary not separated with an empty line
./manila/api/openstack/__init__.py:66:2: H402 one line docstring needs punctuation.
./manila/api/openstack/api_version_request.py:179:1: W391 blank line at end of file
./manila/api/openstack/wsgi.py:145:1: H405 multi line docstring summary not separated with an empty line
./manila/api/openstack/wsgi.py:153:1: H405 multi line docstring summary not separated with an empty line
./manila/api/openstack/wsgi.py:161:1: H405 multi line docstring summary not separated with an empty line
./manila/api/openstack/wsgi.py:264:2: H402 one line docstring needs punctuation.
./manila/api/openstack/wsgi.py:287:2: H402 one line docstring needs punctuation.
./manila/api/openstack/wsgi.py:297:2: H402 one line docstring needs punctuation.
./manila/api/openstack/wsgi.py:561:1: H404 multi line docstring should start without a leading new line
./manila/api/openstack/wsgi.py:561:1: H405 multi line docstring summary not separated with an empty line
./manila/api/openstack/wsgi.py:733:9: M329 LOG.info messages require translations `_LI()`!
./manila/api/openstack/wsgi.py:733:9: M331 Log messages require translations!
./manila/api/openstack/wsgi.py:1062:21: E127 continuation line over-indented for visual indent
./manila/api/openstack/wsgi.py:1197:54: H702 Use bare string concatenation instead of +
./manila/api/openstack/wsgi.py:1321:9: F841 local variable 'metadata' is assigned to but never used
./manila/tests/api/openstack/__init__.py:17:1: F403 'from manila.tests import *' used; unable to detect undefined names
./manila/tests/api/openstack/__init__.py:17:26: H303 No wildcard (*) import.
./manila/tests/api/openstack/test_api_version_request.py:40:80: E501 line too long (88 > 79 characters)
./manila/tests/api/openstack/test_api_version_request.py:46:80: E501 line too long (88 > 79 characters)
./manila/tests/api/openstack/test_wsgi.py:1:1: H102 Apache 2.0 license header not found
./manila/tests/api/openstack/test_wsgi.py:2:1: H305 imports not grouped correctly (ddt: third-party, inspect: stdlib)
./manila/tests/api/openstack/test_wsgi.py:3:1: H305 imports not grouped correctly (inspect: stdlib, mock: third-party)
./manila/tests/api/openstack/test_wsgi.py:164:80: E501 line too long (86 > 79 characters)
./manila/tests/api/openstack/test_wsgi.py:574:13: F841 local variable 'resp_obj' is assigned to but never used
./manila/tests/api/openstack/test_wsgi.py:579:13: F841 local variable 'resp_obj' is assigned to but never used
./manila/tests/api/openstack/test_wsgi.py:701:13: F841 local variable 'resp_obj' is assigned to but never used
./manila/tests/api/openstack/test_wsgi.py:705:13: F841 local variable 'resp_obj' is assigned to but never used
./manila/tests/api/openstack/test_wsgi.py:730:13: F841 local variable 'resp_obj' is assigned to but never used
./manila/tests/api/openstack/test_wsgi.py:734:13: F841 local variable 'resp_obj' is assigned to but never used
./manila/tests/api/openstack/test_wsgi.py:872:1: E302 expected 2 blank lines, found 1

Changed in manila:
assignee: nobody → Hou Ming Wang (houming-wang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/261335

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/261335
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=9a74a01855c58eab16823fbd9912a9a3dd30aeaf
Submitter: Jenkins
Branch: master

commit 9a74a01855c58eab16823fbd9912a9a3dd30aeaf
Author: houming-wang <email address hidden>
Date: Thu Dec 24 09:26:07 2015 -0500

    Fix wrong flake8 exception and pep8 violations

    In the tox.ini, [flake8] section, "exclude =
    .venv,.tox,dist,doc,openstack,*egg". From this rule, all 'openstack'
    directories are excluded. This rule is intended to exclude
    manila/openstack/common code check, but this is wrong
    because it also exclude checks against manila/api/openstack and
    manila/tests/api/openstack. We should fix it

    Change-Id: Ie820e3931e83a82c40b0d9b9d943787a5d6ec363
    Closes-Bug: #1529092

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/manila 2.0.0.0b2

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.