zfs-linux: auto remount fails on reboot

Bug #1521952 reported by Colin Ian King
16
This bug affects 5 people
Affects Status Importance Assigned to Milestone
zfs-linux (Ubuntu)
Fix Released
High
Colin Ian King
Wily
Fix Released
High
Colin Ian King
Xenial
Fix Released
High
Colin Ian King

Bug Description

SRU request, zfs-linux, wily

[IMPACT]
ZFS failes to auto re-mount on a reboot. The reason is two-fold:

1. the /etc/zfs/zpool.cache is not being created correctly and can appear as /etc/zfs/zpool.cache.tmp - this is fixed with upstream commit https://github.com/zfsonlinux/zfs/commit/efc412b
2. the systemd configs for zed and the systemd auto mounting configs were omitted from the original upload.

[TEST CASE]
1 Install zfs
2 create zpool, and some zfs file systems:
  dd if=/dev/zero pf=test.img bs=1M count=1024
  sudo zpool create test /home/user/test.img
  sudo zfs create test/foo
  sudo zfs create test/bar
3 reboot
4 the test/foo and test/bar are not re-mounted

With the fix, the zfs file systems are automounted correctly.

[REGRESSION POTENTIAL]
Limited - change to zpool.cache renaming in the kernel driver is the largest impact, and this has been exercised in upstream versions
The auto remount systemd scripts are from the ZFS-on-Linux packaging and hence have been exercised well.

Changed in zfs-linux (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Colin Ian King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zfs-linux - 0.6.5.3-0ubuntu4

---------------
zfs-linux (0.6.5.3-0ubuntu4) xenial; urgency=medium

  * Add dependency on dh-systemd for zfs-linux (LP: #1521952)
   - Add installinit rules for zed, zfs, mounting and import cache/scan
   - Copy zfs.target to /lib/systemd/system
   - Add bash completion rules
   - Add zed systemd service control
   - Add zfs shared systemd service control
   - Add zfs mount systemd service control
   - Add zfs import scan systemd service control
   - Add zfs import cache systemd service control

 -- Colin Ian King <email address hidden> Wed, 2 Dec 2015 16:50:00 +0000

Changed in zfs-linux (Ubuntu):
status: In Progress → Fix Released
Changed in zfs-linux (Ubuntu):
status: Fix Released → In Progress
Chris J Arges (arges)
Changed in zfs-linux (Ubuntu Wily):
status: New → Fix Released
tags: added: verification-done
Changed in zfs-linux (Ubuntu Wily):
status: Fix Released → In Progress
Changed in zfs-linux (Ubuntu Xenial):
status: In Progress → Invalid
status: Invalid → Fix Released
Changed in zfs-linux (Ubuntu Wily):
importance: Undecided → High
assignee: nobody → Colin Ian King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :

OK, please ignore comment #2, I had messed up on the package version number for Wily, so had to re-spin this.

For wily, see:

https://launchpad.net/~colin-king/+archive/ubuntu/zfs-lp1521952-a
ppa:colin-king/zfs-lp1521952-a

For clarification, for Wily,
   currently in -updates: 0.6.4.2-0ubuntu1.1
   this version: 0.6.4.2-0ubuntu1.2

Revision history for this message
Colin Ian King (colin-king) wrote :

Testing with the package in my PPA fixes the issue. Tested:

1. clean install, install current version -> upgrade to fixed version
2. clean install, install fixed version

a) tested reboot automount
b) tested against kernel team zfs regression tests

Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Colin, or anyone else affected,

Accepted zfs-linux into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zfs-linux/0.6.4.2-0ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in zfs-linux (Ubuntu Wily):
status: In Progress → Fix Committed
Revision history for this message
Colin Ian King (colin-king) wrote :

Tested: zfsutils-linux 0.6.4.2-0ubuntu1.2 (Wily)

a) without fix: automount on reboot fails,
   with fix: automount on reboot works (as expected).

b) tested update -> package update and dkms builds pass.

c) tested zfs tests (from kernel team ZFS tests):
  1) zfs xfs generic - passed
  2) zfs POSIX tests - passed
  3) zfs stress (stress-ng file system) tests -passed
  4) zfs specific tests - no kernel issues - passed

Passed verification based on my ZFS testing criteria.

tags: added: verification-wily-done
removed: verification-done
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zfs-linux - 0.6.4.2-0ubuntu1.2

---------------
zfs-linux (0.6.4.2-0ubuntu1.2) wily; urgency=medium

  [ Colin Ian King ]
  * Add Linux 4.2 compat: add vfs_rename fix patch (LP: #1521952)
   - Add dependency on dh-systemd for zfs-linux
   - Add installinit rules for zed, zfs, mounting and import cache/scan
   - Copy zfs.target to /lib/systemd/system
   - Add bash completion rules
   - Add zed systemd service control
   - Add zfs shared systemd service control
   - Add zfs mount systemd service control
   - Add zfs import scan systemd service control
   - Add zfs import cache systemd service control

 -- Colin Ian King <email address hidden> Tue, 8 Dec 2015 14:50:00 +0000

Changed in zfs-linux (Ubuntu Wily):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for zfs-linux has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.