Ubuntu
ubuntu-release-upgrader package

release upgrader can create a too minimal sources.list

Bug #1511783 reported by Brian Murray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-release-upgrader (Ubuntu)
Fix Released
High
Brian Murray

Bug Description

In the event that the mirror in your /etc/apt/sources.list file is no longer an official mirror of Ubuntu, the release upgrade process will create a new sources.list file for you with only main enabled for the release to which you are upgrading. This will create a poor upgrade experience. This will need to be fixed before or with the fix for bug 1463680.

See original description

Related branches

lp:~brian-murray/ubuntu-release-upgrader/patching-get-distro
Barry Warsaw (community): Needs Fixing
Diff: 332 lines (+167/-23)
3 files modified
DistUpgrade/DistUpgradeController.py (+55/-19)
tests/data-sources-list-test/sources.list.obsolete_mirror (+10/-0)
tests/test_sources_list.py (+102/-4)
lp:ubuntu-release-upgrader
Revision history for this message
Brian Murray (brian-murray) wrote :
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

Here is /var/log/dist-upgrade/main.log from the system which had only main added to its sources.list file.

Revision history for this message
Brian Murray (brian-murray) wrote :

Given that this entry appears in the sources.list file when it is being examined, it must have been added fairly early.

2015-10-30 09:18:14,157 DEBUG examining: 'deb http://archive.ubuntu.com/ubuntu vivid main'
2015-10-30 09:18:14,158 DEBUG entry 'deb http://archive.ubuntu.com/ubuntu wily main' updated to new dist
2015-10-30 09:18:14,158 DEBUG examining: 'deb-src http://mirror.mcs.anl.gov/ubuntu vivid-security main restricted universe multiverse'

Revision history for this message
Brian Murray (brian-murray) wrote :

From what I can tell so far it seems to be an issue with rewriteSourcesList in DistUpgradeController and this part of it.

542 logging.debug("BaseMetaPkg '%s' has no candidate.origins" % pkgname)
 543 try:
 544 distro = get_distro()
 545 distro.get_sources(self.sources)
 546 distro.enable_component("main")

get_distro is from python3-apt and I got as far as figuring out that get_sources ended up creating an empty comps list.

Brian Murray (brian-murray)
tags: added: xenial
Brian Murray (brian-murray)
Changed in ubuntu-release-upgrader (Ubuntu):
assignee: nobody → Brian Murray (brian-murray)
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:16.04.3

---------------
ubuntu-release-upgrader (1:16.04.3) xenial; urgency=medium

  * DistUpgrade/DistUpgradeController.py: if a BaseMetaPkg has no origins,
    because an Ubuntu mirror has been deactivated, then create a useful
    sources.list file that parallels the one for the deactivated mirror.
    (LP: #1511783)
  * utils/update_mirrors.py: Instead of just appending new mirrors to the
    mirrors.cfg file also remove mirrors that are no longer valid.
    (LP: #1463680)

 -- Brian Murray <email address hidden> Wed, 18 Nov 2015 11:05:19 -0800

Changed in ubuntu-release-upgrader (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.