vncviewer from tigervnc requires launching like xvnc4viewer, so may be test to find out which vncviewer binary is used before launching it would be better.
On openSUSE there is /usr/bin/vncviewer-tigervnc actual binary and /usr/bin/vncviewer is link to /etc/alternatives/vncviewer. On suse the attached patch would work, however it does not solve issue with other distributions that install vncviewer binary which is from tigervnc.
For example on CentOS /usr/bin/vncviewer is actual binary provided by tigervnc. Only way I could discover if the binary comes from tigervnc is like this::
if grep TigerVNC /usr/bin/vncviewer; then
echo "this is vncviewer-tigervnc, using vnc4viewer parameters"
elif grep TightVNC /usr/bin/vncviewer; then
echo "this is TightVNC vncviewer, using old school parameters to launch"
else
echo "unknown vncviewer, using .... parameters to launch"
fi
Don't know python equal of this.
cyberorg, please send us another patch that checks for some file that the tigervnc package includes, and launches /usr/bin/vncviewer using the tigervnc syntax in that case.
Thanks!