Ubuntu
ubuntu-drivers-common package

ubuntu-drivers-common should not care about case-sensitivity in modaliases

Bug #1500591 reported by Mathieu Trudel-Lapierre
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
ubuntu-drivers-common (Ubuntu)
Fix Released
High
Alberto Milone
Wily
Triaged
High
Alberto Milone

Bug Description

It seems to me like ubuntu-drivers-common should be able to match modaliases from devices and packages regardless of case; for instance:

alias pci:v000014E4d000043B1sv*sd*bc02sc80i* wl

is the same as

alias pci:v000014E4d000043b1sv*sd*bc02sc80i* wl

Both should match against the same device: 14e4:43b1, which appears to show as uppercase on wily.

Alberto Milone (albertomilone)
Changed in ubuntu-drivers-common (Ubuntu):
status: New → Triaged
importance: Undecided → High
Revision history for this message
Alberto Milone (albertomilone) wrote :

Good point. The current code (i.e. fnmatch.fnmatch()) is case sensitive because the OS is.

Changed in ubuntu-drivers-common (Ubuntu):
assignee: nobody → Alberto Milone (albertomilone)
Alberto Milone (albertomilone)
Changed in ubuntu-drivers-common (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Alberto Milone (albertomilone) wrote :

I've just committed a fix in our git branch. The first step would be to upload this to xenial.

It seems to me that we need to backport the fix to Wily. If so, are there any bugs triggered by this problem?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-drivers-common - 1:0.4.12

---------------
ubuntu-drivers-common (1:0.4.12) xenial; urgency=medium

  [ Alberto Milone ]
  * UbuntuDrivers/detect.py:
    - Make modalias matching case insensitive (LP: #1500591).

  [ Martin Pitt ]
  * debian/tests/system: Explicitly require version 1.0 of UMockdev, to avoid
    a warning on stderr.

 -- Martin Pitt <email address hidden> Mon, 26 Oct 2015 11:03:09 +0100

Changed in ubuntu-drivers-common (Ubuntu):
status: Fix Committed → Fix Released
Alberto Milone (albertomilone)
Changed in ubuntu-drivers-common (Ubuntu Wily):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Alberto Milone (albertomilone)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.