Design Rules error dialog insufficient information

The following patch shows the same information in the dialogue box as in the information window at the bottom of the window.

This will make the error dialogue box more informative and not so cryptic

bzr push lp:~stol/kicad/bug1499538
Using default stacking branch /+branch-id/324654 at chroot-89141904:///~stol/kicad/
Created new stacked branch referring to /+branch-id/324654.

Two comments:

Do we really need to add the same information that is already displayed
in the DRC dialog message panel?

If so, please use an HTML_MESSAGE_BOX to display the formatted error
messages rather than stripping out the html formatting.

well if you don't want the information in a second place maybe it would be ideal to point out in the dialog box to check for errors in the message box, is just unless you realise they will be shown there one won't necessarily look there

Here is another branch, now with HTML message box,
note, it is on a different branch so it is possible to select which
one.

bzr push lp:~stol/kicad/bug1499538_2
Using default stacking branch /+branch-id/324654 at
chroot-63783568:///~stol/kicad/
Created new stacked branch referring to /+branch-id/324654

On Mon, 28 Sep 2015 20:41:11 -0000, Simon Wells
<email address hidden> wrote:
> well if you don't want the information in a second place maybe it would
> be ideal to point out in the dialog box to check for errors in the
> message box, is just unless you realise they will be shown there one
> won't necessarily look there

Here is another branch, now with HTML message box,
note, it is on a different branch so it is possible to select which
one.

bzr push lp:~stol/kicad/bug1499538_2
Using default stacking branch /+branch-id/324654 at
chroot-63783568:///~stol/kicad/
Created new stacked branch referring to /+branch-id/324654

I've taken a closer look at this and I do not like the design of the
design rules dialog. Neither of your solutions solve the fundamental
problem. The design rules validity check should be done before the
dialog is dismissed so the user has a chance to correct any mistakes.
The current design throws away all of the users design rule changes even
if there is only one error. Here is what I would consider a valid fix:

1) Override wxDialog::TransferFromWindow().
2) Move the validity check and transfer code from OnOkButtonClicked() to
   TransferFromWindow().
3) Display HTML error message box from TransferFromWindow() on error and
   return false which will prevent the dialog from closing.
4) If no error, transfer the design rule setting and return true.
5) Remove the message panel from the dialog box.
6) Eliminate OnOkButtonClicked() and OnCancelButtonClicked().
7) Never use this design (handling the OK and cancel buttons directly)
   in any dialogs again.

If you don't have the time or the interest, I will make the changes.

On 9/29/2015 10:31 AM, Stefan wrote:
> Here is another branch, now with HTML message box,
> note, it is on a different branch so it is possible to select which
> one.
>
> bzr push lp:~stol/kicad/bug1499538_2
> Using default stacking branch /+branch-id/324654 at
> chroot-63783568:///~stol/kicad/
> Created new stacked branch referring to /+branch-id/324654
>
>
> On Mon, 28 Sep 2015 20:41:11 -0000, Simon Wells
> <email address hidden> wrote:
>> well if you don't want the information in a second place maybe it would
>> be ideal to point out in the dialog box to check for errors in the
>> message box, is just unless you realise they will be shown there one
>> won't necessarily look there
>

Sounds good, then you get exactly what you want