account-polld plugins hang when displaying a notification on startup

Ok, it's not the Persist() method. It's the following line which is blocking:

avatarPath = qtcontact.GetAvatar(address.Address)

It looks as if the issue is related to the following line from the logs:

QSocketNotifier: Can only be used with threads started with QThread

Inspecting the dbus calls sent by the system, I found out that the contact information request dbus call isn't made until after the timeout (in my updated code) when this bug appears.

Finally fixed this issue! :)

The problems encountered were:

1) Improper multithreading in the go code
2) Qt's and Go's multithreading interfering with each other

For now the code still lies in my imap-mails branch but I'll soon create a separate one for this. ;)

Ok, looks like 2) was indeed fixed by my code but it introduced some other issues so I'll look for a better fix.

Ok, I now found a fix for 2) as well. :)

As this bug really consists of two different ones (the timeout handler not working properly as well as the actual timeout), I split the fix into two different MPs which makes them easier to understand.

https://code.launchpad.net/~nikwen/account-polld/fix-timeout-handler/+merge/273351
https://code.launchpad.net/~nikwen/account-polld/fix-qtcontacts-timeout-error/+merge/273356

I can't reproduce this bug. Is it still an issue?

Yes, this is still an issue. I'll edit the reproduction steps. I forgot something.

Edited. Should be fine now and the two branches fix this.

Thanks, Niklas! I'll take another look at both branches.

Jonas, have you seen my comment on your review? We need to get this in for OTA-8. ;)

Are you sure the steps are good? I really can't reproduce the issue with the steps you've given.

But I'm also not seeing any avatar in the notification indicator, even though the receiving gmail account has access to the contacts.

Yes, that's what I'm doing. However, you should see definitely see avatars in the notification indicator.

Some details on how I added the avatars to the contacts book:

1) Create a new contacts book entry with your own e-mail address and save it in the "personal"/system contacts book.
2) Then add an avatar to it.
3) The avatar should now be shown in the contacts book.

Then:

0) stop ubuntu-push-client
1) Add a Gmail account. Do not grant account to the contacts (even though I don't think that this part is relevant as the contacts are accessed by account-polld and not by the Gmail app).
2) Send yourself an email from the account for which you added the avatar. Send it to the Gmail account you added.

Wait a few seconds and then:

3) start ubuntu-push-client

Starting/stopping ubuntu-push is important as this bug only appears when polling from outside of the regular polling mechanism, e.g. when the account is initialized in account-polld!

This bug was fixed in the package account-polld - 0.1+16.04.20151103-0ubuntu1

---------------
account-polld (0.1+16.04.20151103-0ubuntu1) xenial; urgency=medium

  [ Niklas Wenzel ]
  * Fix a timeout error in the qtcontacts module which occured when a
    notification was shown directly after creating an account (fixes LP:
    #1498214) (LP: #1498214)
  * Fix the timeout logic in the qtcontacts module (part of LP:
    #1498214) (LP: #1498214)

 -- <email address hidden> (Jonas G. Drange) Tue, 03 Nov 2015 13:40:49 +0000