Number of .desktop files check should not error

Bug #1496402 reported by Alan Pope 🍺🐧🐱 🦄
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Fix Released
Undecided
Unassigned

Bug Description

We currently check for the number of .desktop files in a click, and error when it's more than one.

We allow multiple .desktop files in a click on the device, and this works correctly.

We should switch the error to be a warning when the number of .desktop files is not 1.

Example click:- http://people.canonical.com/~alan/multi-desktop-click.sil_0.1_all.click
This installs two separate qml files launched from different icons (which happen to be the same looking icon. note).
You can launch both and remove both via long-press.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

A warning will trigger a manual review in the store. If everything is working correctly today, then this check should either be a warning or removed entirely. Has anyone checked with the store devs to confirm everything is ok on their end with multiple .desktop files?

Changed in click-reviewers-tools:
status: New → Incomplete
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

err: it should either be 'info' or removed entirely.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

08:50 < JamesTait> popey, off the top of my head, the only scanning we do of the .desktop file is in click-reviewers-tools on the server. So I don't think it'll cause a problem.

Changed in click-reviewers-tools:
status: Incomplete → In Progress
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Ok, I'll adjust to info for now-- if it causes a problem somewhere, we can revert it.

summary: - Number of .desktop files check should issue warning, not error
+ Number of .desktop files check should not error
Changed in click-reviewers-tools:
status: In Progress → Fix Committed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Note, it was brought up that this means that .desktop apps within the same app can share data. This is by design-- apps are user-driven and we want to allow data sharing between apps where we can (ie, where the security context is the same-- in this case a gui app from the same developer in the same click (as opposed to, say, a push helper that has no user interaction and runs behind the scenes)). Any abuses of this data sharing should be reported to the store (just like abuses of a single .desktop app).

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I pinged the store guys and they will pull this change into the store on their next rollout.

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This was fixed in 0.34.

Changed in click-reviewers-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.