Can't use gmail+new-verbose-footers to filter by group rationale

Perhaps we should switch to appending @your-username in that case. It would potentially break other people's filters.

Or maybe "Launchpad-Message-Rationale: Reviewer via ~your-team" or something similar?

I think "Reviewer @your-username" would be semantically more sound - "via" is already used for something slightly different elsewhere, and I would rather not break existing team filters as well.

OK. Note that "Subscriber" has the same issue, though hopefully that's all the same code path in Launchpad anyway.

Yes, bugs go through a different code path because it was too heroic a job to convert them, but everything else goes through the same path for rationale construction.

We talked about this a bit on #launchpad-dev today. The problem with changing the existing rationales is that people may well have filters that direct anything without @ (i.e. notifications directed specifically at them) to their inbox and anything with @ to a "team junk I don't care about" mailbox, so adding @ would potentially cause people to not see notifications and not notice for some time.

How about sidestepping the issue and introducing a new header? X-Launchpad-Message-Subscriber or some such, that always identifies the person-or-team that the notification is being sent to. We could leave @ in X-Launchpad-Message-Rationale intact for compatibility, but the new preferred approach would be to filter on this new header.

Right. That "aimed at me" vs "team junk I don't care about" issue is exactly the filtering I'm trying to do.

I will point out that in terms of what you put in the FOOTER, which is ostensibly 99% for Gmail users: Gmail won't let you filter by @ at all (hence this bug). So there's no compatibility issue with existing filters.

But you keep talking about headers. So I'm assuming you're trying to keep the footers identical to the headers. In which case, yeah, 100% don't change the actual Rationale header. Only changing the footer version would make sense. But if you want them the same...

I'm fine with a new header.

Right, the footers are intentionally totally identical to the headers (well, anything that starts with X-Launchpad- and with the leading "X-" stripped). That's the only reason the expanded footer approach is sustainable. I wouldn't want to do anything that makes them different.

Fixed in stable r17730 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17730>.