typing in search field of date/time settings blocks UI

Bug #1492260 reported by Bill Filler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Medium
Bill Filler
ubuntu-system-settings (Ubuntu)
Fix Released
Medium
Jonas G. Drange

Bug Description

Steps to reproduce:
- reflash your phone
- go to date/time settings
- start typing "Boston" in search field

Expected results:
- Should see the text "Boston" immediately entered into the search field, with results updated as each letter is typed

Actual results:
- I only see "B" entered into the text field and everything blocks until the first set of search results comes back, then "Boston" is filled in the text field

Seems the search must be happening in the same thread as UI which is causing typing of the search string to block

Related branches

Bill Filler (bfiller)
Changed in canonical-devices-system-image:
milestone: none → ww40-2015
assignee: nobody → Bill Filler (bfiller)
importance: Undecided → Medium
status: New → Confirmed
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Jonas G. Drange (jonas-drange)
importance: Undecided → Medium
Revision history for this message
Iain Lane (laney) wrote : Re: [Bug 1492260] [NEW] typing in search field of date/time settings blocks UI

On Fri, Sep 04, 2015 at 01:14:11PM -0000, Bill Filler wrote:
> Public bug reported:
>
> Steps to reproduce:
> - reflash your phone
> - go to date/time settings
> - start typing "Boston" in search field
>
> Expected results:
> - Should see the text "Boston" immediately entered into the search field, with results updated as each letter is typed
>
> Actual results:
> - I only see "B" entered into the text field and everything blocks until the first set of search results comes back, then "Boston" is filled in the text field
>
> Seems the search must be happening in the same thread as UI which is
> causing typing of the search string to block

No, we use QtConcurrent to do that.

It's probably something else, like incorrect blocking or maybe a
different part which is done synchronously.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Changed in ubuntu-system-settings (Ubuntu):
status: New → In Progress
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

It seems we can improve the following and kill this bug in the process:
 * move qSort out of GUI thread into the worker thread,
 * instantiate timedatepanel plugin only once,
 * and move away from the deprecated pattern of subclassing QThread.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+15.10.20150918-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.10.20150918-0ubuntu1) wily; urgency=medium

  [ jonas-drange ]
  * [hotspot] hide/show based on modem availability from Connectivity
    (which also requires a bumped dep). (LP: #1487157)
  * [time-date] Migrate threaded code to worker-object pattern, move
    sorting to a worker thread from the GUI thread, and only instantiate
    UbuntuTimeDatePanel plugin once. (LP: #1492260)
  * [wifi/wpa2ep] allow passwords of length 1 for wpa enterprise
    authentication schemes. (LP: #1490417)

 -- <email address hidden> (Jonas G. Drange) Fri, 18 Sep 2015 14:20:27 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: Confirmed → Fix Committed
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.