MAAS

MAAS power query does not work for Python power drivers

Bug #1485677 reported by Andres Rodriguez
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Newell Jensen
MAAS 1.9.0

Bug Description

The MAAS power querying mechanism is not working for the MAAS python power drivers. This was found right after landing the IPMI python power driver.

Related branches

lp:~allenap/maas/revert-ipmi-power-driver
Andres Rodriguez (community): Approve
Diff: 654 lines (+130/-469)
6 files modified
etc/maas/templates/power/ipmi.conf (+4/-0)
etc/maas/templates/power/ipmi.template (+110/-0)
src/provisioningserver/drivers/power/__init__.py (+0/-2)
src/provisioningserver/drivers/power/ipmi.py (+0/-154)
src/provisioningserver/drivers/power/tests/test_ipmi.py (+0/-312)
src/provisioningserver/power/tests/test_poweraction.py (+16/-1)
lp:~andreserl/maas/lp1485677
Gavin Panella (community): Approve
Diff: 15 lines (+0/-5)
1 file modified
src/provisioningserver/rpc/power.py (+0/-5)
Revision history for this message
Newell Jensen (newell-jensen) wrote :

Andres,

Can you please let me know what the error is. Using the same code that was reverted, I do not get any power query errors/issues on the hardware that I have been testing on.

Thanks.

Changed in maas:
assignee: nobody → Newell Jensen (newell-jensen)
Andres Rodriguez (andreserl)
Changed in maas:
importance: Undecided → Critical
milestone: none → 1.9.0
Revision history for this message
Gavin Panella (allenap) wrote :

For IPMI at least, the problem appears to be bad data. Power parameters
are stored in the power_parameters JSON field on the Node.

* If no choice is made for the "Power driver" field in the UI, the value
  stored for "power_driver" is the following *list*:

    ["LAN_2_0", "LAN_2_0 [IPMI 2.0]"]

* Once "LAN_2_0 [IPMI 2.0]" is selected in the UI, "power_driver" is set
  to the *string* "LAN_2_0" in the database.

* Selecting "LAN [IPMI 1.5]" in the UI causes the "power_driver" setting
  to disappear from the power parameters stored in the database.

It's not the driver's fault the data is bad. Ideally it wouldn't be the
driver's responsibility to deal with this bad data, but pragmatically we
may want it to.

Likely next steps:

-> Update IPMI driver to deal with bad data and DTRT.

-> Fix validation of power parameters to avoid adding new bad data.

-> Fix existing power parameters in running MAAS installations.

Revision history for this message
Gavin Panella (allenap) wrote :

While we're fixing validation, we should also fix the whitespace issue identified in bug 1484551.

Gavin Panella (allenap)
Changed in maas:
status: New → Triaged
Revision history for this message
Gavin Panella (allenap) wrote :

This is fixed now, right?

Revision history for this message
Newell Jensen (newell-jensen) wrote :

Yes. All the new power driver code changes fixed this AFAIK.

Gavin Panella (allenap)
Changed in maas:
status: Triaged → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.