Requests to the package index are not oauth signed
Bug #1483866 reported by
Natalia Bidart
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Alejandro J. Cura | ||
| unity-scope-click (Ubuntu) |
Fix Released
|
High
|
dobey | ||
Bug Description
We have added support to the package index so results can be customized depending on the user making the request. Specifically, to make use of the new feature about private packages, the request to the package index must to be oauth signed, otherwise only public package information will be returned.
So, when possible, we should have all queries directed to the package index to be oauth signed, with the SSO oauth token the device has stored.
Related branches
lp:~dobey/unity-scope-click/sign-all
- PS Jenkins bot: Approve (continuous-integration)
- Alejandro J. Cura (community): Approve
-
Diff: 68 lines (+38/-2)2 files modifiedlibclickscope/click/index.cpp (+2/-2)
libclickscope/tests/test_index.cpp (+36/-0)
lp:~dobey/unity-scope-click/sign-all-vivid
- Alejandro J. Cura (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 68 lines (+38/-2)2 files modifiedlibclickscope/click/index.cpp (+2/-2)
libclickscope/tests/test_index.cpp (+36/-0)
lp:~alecu/unity-scope-click/sso-for-signatures
- dobey (community): Needs Fixing
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 118 lines (+33/-4)7 files modifiedlibclickscope/click/webclient.cpp (+1/-1)
libclickscope/click/webclient.h (+1/-1)
libclickscope/tests/mock_webclient.h (+2/-2)
libclickscope/tests/test_index.cpp (+12/-0)
libclickscope/tests/test_reviews.cpp (+13/-0)
scope/clickapps/apps-scope.cpp (+2/-0)
scope/clickstore/store-scope.cpp (+2/-0)
lp:~unity-api-team/unity-scope-click/sign-all-the-things
- Charles Kerr (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 440 lines (+107/-54)17 files modifiedlibclickscope/click/download-manager.cpp (+2/-3)
libclickscope/click/pay.cpp (+0/-3)
libclickscope/click/preview.cpp (+0/-4)
libclickscope/click/ubuntuone_credentials.cpp (+41/-1)
libclickscope/click/ubuntuone_credentials.h (+3/-2)
libclickscope/click/webclient.cpp (+15/-19)
libclickscope/click/webclient.h (+1/-1)
libclickscope/tests/mock_ubuntuone_credentials.h (+5/-5)
libclickscope/tests/mock_webclient.h (+2/-3)
libclickscope/tests/test_download_manager.cpp (+2/-4)
libclickscope/tests/test_index.cpp (+13/-1)
libclickscope/tests/test_reviews.cpp (+13/-0)
libclickscope/tests/test_webclient.cpp (+4/-8)
scope/clickapps/apps-scope.cpp (+2/-0)
scope/clickapps/apps-scope.h (+1/-0)
scope/clickstore/store-scope.cpp (+2/-0)
scope/clickstore/store-scope.h (+1/-0)
lp:~dobey/unity-scope-click/really-we-want-to-sign-all-the-requests
- Charles Kerr (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 454 lines (+109/-55)18 files modifiedlibclickscope/click/download-manager.cpp (+2/-3)
libclickscope/click/pay.cpp (+0/-3)
libclickscope/click/preview.cpp (+0/-4)
libclickscope/click/reviews.cpp (+2/-1)
libclickscope/click/ubuntuone_credentials.cpp (+41/-1)
libclickscope/click/ubuntuone_credentials.h (+3/-2)
libclickscope/click/webclient.cpp (+15/-19)
libclickscope/click/webclient.h (+1/-1)
libclickscope/tests/mock_ubuntuone_credentials.h (+5/-5)
libclickscope/tests/mock_webclient.h (+2/-3)
libclickscope/tests/test_download_manager.cpp (+2/-4)
libclickscope/tests/test_index.cpp (+13/-1)
libclickscope/tests/test_reviews.cpp (+13/-0)
libclickscope/tests/test_webclient.cpp (+4/-8)
scope/clickapps/apps-scope.cpp (+2/-0)
scope/clickapps/apps-scope.h (+1/-0)
scope/clickstore/store-scope.cpp (+2/-0)
scope/clickstore/store-scope.h (+1/-0)
lp:~marcustomlinson/unity-scope-click/without-crashing
- dobey (community): Approve
- Paweł Stołowski (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 113 lines (+16/-0)4 files modifiedscope/clickapps/apps-scope.cpp (+4/-0)
scope/clickapps/apps-scope.h (+4/-0)
scope/clickstore/store-scope.cpp (+4/-0)
scope/clickstore/store-scope.h (+4/-0)
| Changed in unity-scope-click (Ubuntu): | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Rodney Dawes (dobey) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity-scope-click (Ubuntu): | |
| status: | In Progress → Fix Released |
Revision history for this message
| Alejandro J. Cura (alecu) wrote | #2 |
| Changed in unity-scope-click (Ubuntu): | |
| status: | Fix Released → Triaged |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| importance: | Undecided → High |
| status: | New → In Progress |
| milestone: | none → ww02-2016 |
| Changed in canonical-devices-system-image: | |
| milestone: | ww02-2016 → ww08-2016 |
| Changed in unity-scope-click (Ubuntu): | |
| assignee: | Rodney Dawes (dobey) → Antti Kaijanmäki (kaijanmaki) |
| Changed in unity-scope-click (Ubuntu): | |
| assignee: | Antti Kaijanmäki (kaijanmaki) → Rodney Dawes (dobey) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in unity-scope-click (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| dobey (dobey) wrote | #4 |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Confirmed |
| Changed in unity-scope-click (Ubuntu): | |
| status: | Fix Released → Confirmed |
| Changed in canonical-devices-system-image: | |
| milestone: | ww08-2016 → 11 |
| Changed in unity-scope-click (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in unity-scope-click (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in unity-scope-click (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package unity-scope-click - 0.1.1+15.
---------------
unity-scope-click (0.1.1+
[ Robert Ancell ]
* Depend on upstart instead of upstart-bin which is a dummy
transitional package.
[ Rodney Dawes ]
* Sign the requests to CPI by default. Add tests to ensure signing is
requested. (LP: #1483866)
-- CI Train Bot <email address hidden> Wed, 12 Aug 2015 13:34:30 +0000