cannot resize surfaces from the WindowManager when the display changes
Bug #1481418 reported by
Kevin DuBois
This bug report is a duplicate of:
Bug #1471909: MultiThreadedCompositor::destroy_compositing_threads hangs/deadlocks on shutdown or display reconfiguration.
Edit
Remove
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Committed
|
High
|
Kevin DuBois | ||
Bug Description
The USC in Silo0 wants to resize the surfaces as a result of a display configuration cahnge. This will go through our observer infrastructure and try to schedule a frame, resulting in a deadlock.
Related branches
lp:~kdub/mir/fix-silo0-1480418
- Mir development team: Pending requested
-
Diff: 63 lines (+39/-2)2 files modifiedsrc/server/compositor/multi_threaded_compositor.cpp (+2/-2)
tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+37/-0)
lp:~kdub/mir/tests-for-1480418
- Daniel van Vugt: Approve
- Chris Halse Rogers: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 44 lines (+37/-0)1 file modifiedtests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+37/-0)
lp:~mir-team/mir/silo0
- Mir development team: Pending requested
-
Diff: 785 lines (+300/-34) (has conflicts)33 files modified3rd_party/android-deps/android/input.h (+1/-1)
3rd_party/android-input/android/frameworks/base/services/input/InputReader.cpp (+3/-0)
3rd_party/android-input/android/frameworks/base/services/input/InputTransport.cpp (+3/-2)
cross-compile-chroot.sh (+2/-0)
debian/changelog (+9/-0)
include/client/mir/events/event_builders.h (+8/-0)
include/client/mir_toolkit/events/input/pointer_event.h (+6/-1)
include/test/mir_test/event_matchers.h (+14/-0)
src/client/event_printer.cpp (+2/-0)
src/client/events/event_builders.cpp (+15/-2)
src/client/input/android/android_input_lexicon.cpp (+3/-1)
src/client/input/input_event.cpp (+5/-1)
src/include/common/mir/events/event_private.h (+2/-0)
src/platforms/android/server/display.cpp (+5/-3)
src/platforms/android/server/display.h (+1/-0)
src/platforms/android/server/display_buffer.cpp (+3/-0)
src/platforms/android/server/display_group.cpp (+25/-5)
src/platforms/android/server/display_group.h (+2/-0)
src/platforms/android/server/real_hwc_wrapper.cpp (+1/-1)
src/server/compositor/multi_threaded_compositor.cpp (+2/-2)
src/server/graphics/software_cursor.cpp (+3/-2)
src/server/input/android/input_sender.cpp (+2/-0)
src/server/input/android/input_translator.cpp (+11/-7)
src/server/input/surface_input_dispatcher.cpp (+3/-2)
tests/acceptance-tests/test_client_input.cpp (+34/-0)
tests/mir_test_framework/fake_input_device_impl.cpp (+3/-1)
tests/unit-tests/compositor/test_multi_threaded_compositor.cpp (+37/-0)
tests/unit-tests/graphics/android/test_display.cpp (+45/-0)
tests/unit-tests/graphics/android/test_display_group.cpp (+26/-0)
tests/unit-tests/graphics/test_software_cursor.cpp (+15/-0)
tests/unit-tests/input/android/test_android_input_sender.cpp (+1/-1)
tests/unit-tests/input/android/test_input_translator.cpp (+7/-1)
tests/unit-tests/input/test_input_event.cpp (+1/-1)
Revision history for this message
| Kevin DuBois (kdub) wrote | #1 |
| Changed in mir: | |
| milestone: | none → 0.15.0 |
| Changed in mir: | |
| milestone: | 0.15.0 → 0.16.0 |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #2 |
| Changed in mir: | |
| milestone: | 0.16.0 → 0.15.0 |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
Seems that tip mir has had this fixed in 2731 as a part of fixing lp: 1471909. I had written some tests in the silo0 code for this case specificically, which are up for review:
lp:~kdub/mir/tests-for-1480418
The backport of the fix for silo0 is in:
lp:~kdub/mir/fix-silo0-1480418