oops / fwts log didn't get uploaded correctly

Bug #1481304 reported by Po-Hsu Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
High
Sylvain Pineau

Bug Description

The oops_results.log for miscellanea/oops test can't be uploaded to C3 correctly with rev 3931, because the fwts_test script will add a trailing "_hwe" to the log file filename, make it become fwts_oops_results_hwe.log

Not sure if this is intended, or maybe it's a part of of change of the new fwts.

Related branches

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

This also affect the fwts_desktop_diagnosis_results.log

summary: - oops log didn't get uploaded correctly
+ oops / fwts log didn't get uploaded correctly
Changed in plainbox-provider-checkbox:
assignee: nobody → Po-Hsu Lin (cypressyew)
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Just checked the merge request, this was changed in rev 3927 [1],

HWE_TESTS = ['mtrr',
                             'virt',
                             'apicedge',
                             'klog',
                             'oops',
                             'uefibootpath']

These test will have an extra _hwe in the filename, and the oops test is in the list.

For the fwts test, it also includes the klog test (in CERT_TESTS list), therefore the file will be renamed as well.

http://bazaar.launchpad.net/~checkbox-dev/checkbox/trunk/revision/3927

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

After re-run the fwts diagnostics test, I noticed that it's not renaming the log file, it will generate two reports for the test,
the klog part will be saved with _hwe string.

Therefore I think if fwts_desktop_diagnosis_results.log was successfully uploaded to C3, it's still not a complete report.
(in this case, I am not sure why it's not uploaded even with the correct filename, see the submission of 201408-15450)

To solve this, maybe we will need to figure out why we need the _hwe string in the filename.
(Maybe it's easier to find those report that HWE would like to investigate?)

Changed in plainbox-provider-checkbox:
assignee: Po-Hsu Lin (cypressyew) → nobody
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Hmm. I think this is good now. There are more jobs than before (one for normal and another for _hwe.log).

(venv.virtual-fx)zyga@virtual-fx:~/checkbox/providers$ grep -R hwe.log plainbox-provider-checkbox/ plainbox-provider-certification-client/ plainbox-provider-certification-server/
plainbox-provider-checkbox/bin/fwts_test: log = log.replace('.log', '_hwe.log')
plainbox-provider-checkbox/jobs/firmware.txt.in:id: firmware/fwts_desktop_diagnosis_results_hwe.log
plainbox-provider-checkbox/jobs/firmware.txt.in: [ -f $PLAINBOX_SESSION_SHARE/fwts_desktop_diagnosis_results_hwe.log ] && gzip -c $PLAINBOX_SESSION_SHARE/fwts_desktop_diagnosis_results_hwe.log | base64
plainbox-provider-certification-client/units/client-cert-14-04-3.pxu: firmware/fwts_desktop_diagnosis_results_hwe.log

Looking at this you can see that there is a new attachment job and it is used in client-cert-14-04-3 test plan.

Changed in plainbox-provider-checkbox:
status: Confirmed → Incomplete
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I'm marking this as incomplete. Please reopen if you think there's something more to be done around this issue. Thanks

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Cool,
Didn't notice that we already have it in the 14.04.3 test plan.

I will need to separate these issue this into 3 parts:
1. We will need to reflect this back into our dev whitelist (client cert)
2. These two attachments are empty on C3 (tested with 14.04.3 test plan)
https://certification.canonical.com/hardware/201307-14037/submission/105433/
please refer to this submission
3. OOPS log attachment job needs to be fixed.

Changed in plainbox-provider-checkbox:
status: Incomplete → Confirmed
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Since these are different issues, I will separate the bug report to it.

Please refer to http://pad.lv/1483598 for the first issue (fwts attachment job change for all test plans)
And http://pad.lv/1484885 for the oops log attachment issue.

Changed in plainbox-provider-checkbox:
assignee: nobody → Sylvain Pineau (sylvain-pineau)
Changed in plainbox-provider-checkbox:
status: Confirmed → Fix Committed
Po-Hsu Lin (cypressyew)
Changed in plainbox-provider-checkbox:
milestone: none → 0.22
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.