[browser] Bookmark Link action from popup menu should invoke bookmark folder UI or provide some sort of feedback that action succeeded
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UX |
Fix Released
|
Medium
|
James Mulholland | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Ugo Riboni | ||
Bug Description
Now that we have a UI for creating bookmark folders, this should be invoked when pressing "bookmark link" from context menu. Currently no ui is shown and there is no feedback that the action succeeded.
--- --- --- ---
UX Comment:
I agree with Bill's suggestion:
"...we should basically use the same UI components that provides a field for name, save in, and new folder and just not display it beneath the star or light up the star."
We should also position the components to appear in the same place as the contextual options menu that allows links to be bookmarked.
Additionally;
- Once a link has been bookmarked (either through the contextual options or address bar), the option to 'Bookmark link' should no longer be present in the contextual options menu associated with that link.
- Upon visiting a link bookmarked via contextual options, the star within the address-bar should appear 'lit' (which doesn't appear to currently be the case).
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Olivier Tilloy: Approve
-
Diff: 492 lines (+147/-74)10 files modifiedsrc/app/UrlUtils.js (+10/-5)
src/app/webbrowser/AddressBar.qml (+2/-1)
src/app/webbrowser/Browser.qml (+23/-10)
src/app/webbrowser/Chrome.qml (+3/-0)
src/app/webbrowser/NavigationBar.qml (+2/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+36/-0)
tests/autopilot/webbrowser_app/tests/__init__.py (+2/-1)
tests/autopilot/webbrowser_app/tests/test_bookmark_options.py (+35/-5)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+20/-52)
tests/unittests/qml/tst_UrlUtils.qml (+14/-0)
| Olivier Tilloy (osomon) wrote | #1 |
| summary: |
- Bookmark Link action from popup menu should invoke bookmark folder UI or - provide some sort of feedback that action succeeded + [browser] Bookmark Link action from popup menu should invoke bookmark + folder UI or provide some sort of feedback that action succeeded |
| Changed in ubuntu-ux: | |
| status: | New → Triaged |
| assignee: | nobody → James Mulholland (jamesjosephmulholland) |
| importance: | Undecided → Medium |
| Bill Filler (bfiller) wrote | #2 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| description: | updated |
| Changed in ubuntu-ux: | |
| status: | Triaged → Fix Committed |
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Ugo Riboni (uriboni) |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Confirmed → In Progress |
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-ux: | |
| status: | Fix Committed → Fix Released |
Need some guidance from design on this. I don’t think we can re-use the same popup that shows up when bookmarking the current page, that would be misleading as this popup points to the star in the address bar, which shouldn’t turn orange when bookmarking a different page.