AWN doesn't update window's status

http://www.planetblur.org/hosted/awnforum/index.php?shard=forum&action=g_reply&ID=1127&page=1&isLive=true

Fixed in R136.

The following patch actually checks the version of libwnck to see if the version installed has the ABI change from version 2.19.3.1 and later.

Thanks, now in trunk R137.

This is minor, but it annoys those of us developers building with the -Wall CFLAG. The following patch compiles only one of the wnck callback functions, to avoid the error "warning: xyz defined but not used."

According to some libwnck 2.20 users, there is a small glitch in awn-wnck-Wall-fix.patch . The following patch is meant to be applied over the former one.

Why did you put the connection of "viewports-changed" signal in the ifdef? This signal is available also in libwnck <2.20.

Not according to the docs: http://library.gnome.org/devel/libwnck/stable/WnckScreen.html#WnckScreen-viewports-changed

The doc is wrong, take a look for example here: http://ftp.gnome.org/pub/GNOME/sources/libwnck/2.4/libwnck-2.4.0.1.tar.bz2

The signal is already present there - libwnck/screen.c (libwnck 2.4), maybe it's there even in older releases.

Bug filed with libwnck in Gnome bugzilla. I'll fix the patch shortly.

The following patch *replaces* -rev1, and removes the #ifdef from the "viewports-changed" signal.

Sigh. Via Vincent Untz (libwnck maintainer) in the referenced bug on Gnome bugzilla, it was not part of the public interface until libwnck 2.19.3. In fact, it was introduced in the middle of an "#if 0" block. So, -rev1 is indeed a correct patch.

Thanks for clarifying, but in that case the signal is currently useless for us, and we don't need to connect it at all.

Right, which is why it's #ifdef'd out in -rev1.

Yea, it's #ifdef'd, but it can be removed, we'll have a performance boost and smaller code size. ;D

0.2.1 released