Ubuntu
ubuntu-system-settings package

[plugin] allow dynamic name

Bug #1475629 reported by Jonas G. Drange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-system-settings (Ubuntu)
Fix Released
High
Jonas G. Drange

Bug Description

Reproduce (always, trunk):
Try changing a plugin's name dynamically.

What happens:
You can't.

What should happen:
You should be able to change the name dynamically, like you can the icon, keywords and visibility.

Solution:
Add
    void setDisplayName(const QString &name);

to existing interface which provides:
    void setIcon(const QUrl &icon);
    void setKeywords(const QStringList &keywords);
    void setVisible(bool visible);

I do not think name of plugin should change, as this could have implications elsewhere. Only the displayName should change.

Related branches

lp:~jonas-drange/ubuntu-system-settings/has-dynamic-name
Ken VanDine: Approve
PS Jenkins bot: Needs Fixing (continuous-integration)
Sebastien Bacher (community): Approve
Diff: 218 lines (+73/-6)
7 files modified
lib/SystemSettings/item-base.cpp (+16/-0)
lib/SystemSettings/item-base.h (+4/-0)
src/plugin.cpp (+8/-1)
src/plugin.h (+2/-1)
tests/data/brightness.settings (+14/-0)
tests/test-plugin.cpp (+9/-3)
tests/tst_plugins.cpp (+20/-1)
lp:ubuntu/wily-proposed/ubuntu-system-settings
Revision history for this message
Sebastien Bacher (seb128) wrote :

What's the usecase?

Changed in ubuntu-system-settings (Ubuntu):
status: New → Incomplete
importance: Undecided → Wishlist
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

From [1]:

    The System Settings main screen should have an item named
    according to the device capabilities: “Displays” if it allows multiple
    simultaneous displays; otherwise “Brightness & Display” if it allows
    switching to an external display (Pocket PC); otherwise just “Brightness”.

[1] https://wiki.ubuntu.com/BrightnessAndDisplays#Phone-1

Jonas G. Drange (jonas-drange)
Changed in ubuntu-system-settings (Ubuntu):
status: Incomplete → Confirmed
importance: Wishlist → High
Jonas G. Drange (jonas-drange)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Jonas G. Drange (jonas-drange)
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+15.10.20150827-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.10.20150827-0ubuntu1) wily; urgency=medium

  [ Ken VanDine ]
  * Don't show the phone number in the about page, that is now provided
    by address-book-app (LP: #1364452)

  [ Robert Ancell ]
  * Use new QML package names for qml-module-qt-labs-folderlistmodel,
    qml-module-qtsysteminfo.

  [ Sebastien Bacher ]
  * [security-privacy] rename the "Lock phone" item to "Locking and
    unlocking" and do not include the screen delay as a value, it
    misleads users to think that the section is only about that where it
    also includes security options (LP: #1361127)
  * [security-privacy] use the correct access to location string (LP:
    #1388184)

  [ jonas-drange ]
  * Use wait_select_single instead of select_single to make the test
    less flaky
  * [plugin] add has-dynamic-name to allow for dynamic renaming of a
    plugin. (LP: #1475629)

 -- CI Train Bot <email address hidden> Thu, 27 Aug 2015 07:47:59 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.