tools/maas2roottar doesn't exit non-zero if mount-image-callback is not installed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
curtin |
Fix Released
|
Low
|
Unassigned | ||
curtin (Ubuntu) |
Fix Released
|
Low
|
Unassigned | ||
Trusty |
Fix Released
|
Low
|
Unassigned | ||
Vivid |
Fix Released
|
Low
|
Unassigned |
Bug Description
I'm using maas2roottar to unpack the maas image in a script like so:
[ "$?" != "0" ] && {
log "ERROR: Failed to convert ephemeral to roottar";
return 1;
}
But on a system that didn't have mount-image-
/home/
sudo: mount-image-
+ '[' 0 '!=' 0 ']'
looking at the call in maas2roottar; it just needs a check on the return code of mount-image-
$sudo mount-image-
${vflags} "${pt[@]}" _MOUNTPOINT_ "$output"
1. % lsb_release -rd
Description: Ubuntu 14.04.2 LTS
Release: 14.04
2. % bzr info
Standalone tree (format: 2a)
Location:
branch root: .
Related branches:
parent branch: bzr+ssh:
(foudres) curtin % bzr revno
214
3. maas2roottar return non-zero if mount-image-
4. maas2roottar did not exit non-zero on system witout mount-image-
no longer affects: | curtin (Ubuntu) |
Changed in curtin: | |
importance: | Undecided → Low |
Changed in curtin (Ubuntu): | |
importance: | Undecided → Low |
Changed in curtin (Ubuntu Trusty): | |
importance: | Undecided → Low |
Changed in curtin (Ubuntu Vivid): | |
importance: | Undecided → Low |
fixed in trunk at 223.
I removed the ubuntu task as this program is not shipped in the package so its not really a bug against ubuntu.