Unable to set "merged at revision" using launchpad UI for git merge requests
Bug #1462436 reported by
Zygmunt Krynicki
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
Attempts to set merged-at-revision for the following git merge request [1] fail without giving any OOPS id.
The branch has been merged (fast forward) and I wanted to manually set the merged-at-revision to the appropriate value but it seems that the value is ignored. A successful message is flashed though.
[1] https:/
Related branches
lp:~cjwatson/launchpad/git-merged-revno
- William Grant: Approve (code)
-
Diff: 316 lines (+99/-111)8 files modifiedlib/lp/code/browser/branchmergeproposal.py (+4/-1)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+74/-40)
lib/lp/code/interfaces/branchmergeproposal.py (+4/-0)
lib/lp/code/model/branchmergeproposal.py (+8/-0)
lib/lp/code/stories/branches/xx-branchmergeproposals.txt (+0/-61)
lib/lp/code/templates/branch-macros.pt (+3/-3)
lib/lp/code/templates/branchmergeproposal-link-summary.pt (+3/-3)
lib/lp/code/templates/branchmergeproposal-pagelet-summary.pt (+3/-3)
Revision history for this message
| Colin Watson (cjwatson) wrote | #1 |
| tags: | added: git trivial ui |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We need to show merged_revision_id here for git rather than merged_revno.