Unused "Check component compatibility and certification" field should be removed

From maas-devel https://lists.launchpad.net/maas-devel/msg02084.html -

For some time there's been a checkbox on the Settings page for
Commissioning that says:

Check component compatibility and certification

What exactly does that do?

I checked it on my 1.8 MAAS server and did a commissioning but didn't
notice if it was trying to contact the cert repository or some other
place or no, and after commissioning there is no indication that my
system was checked, nor that it is or is not full of certified
components...

So any idea what this checkbox does, and if it does nothing, why is it there?

Thanks!

Jeff

   I did a few quick greps through the code:

$ bzr grep -i "Check component compatibility and certification"
src/maasserver/forms_settings.py: 'label': "Check component compatibility and certification"

In forms_settings.py:
"""
    'check_compatibility': {
        'default': False,
        'form': forms.BooleanField,
        'form_kwargs': {
            'required': False,
            'label': "Check component compatibility and certification"
        }
    },
"""'

---

   Looking for the configuration key, it looks like it isn't used for anything:

$ bzr grep check_compatibility
src/maasserver/forms.py: check_compatibility = get_config_field('check_compatibility')
src/maasserver/forms_settings.py: 'check_compatibility': {
src/maasserver/models/config.py: 'check_compatibility': False,
src/maasserver/views/tests/test_settings.py: new_check_compatibility = factory.pick_bool()
src/maasserver/views/tests/test_settings.py: 'check_compatibility': new_check_compatibility,
src/maasserver/views/tests/test_settings.py: new_check_compatibility,
src/maasserver/views/tests/test_settings.py: Config.objects.get_config('check_compatibility'),

$ bzr log -r $(bzr blame src/maasserver/forms.py | grep check_compat | awk '{ print $1 }') | grep timestamp
timestamp: Thu 2013-05-16 16:31:31 +0200

   Right now, all indications are that this functionality is a no-op, and hasn't been touched since 2013. (way before my time)

   I'd vote +1 for removing this field.

Regards,
Mike

---

Good catch! Let's remove for now. The intent was that it would flag and
badge any uncertified components.

Mark