snappy oauth quoting incorrect
Bug #1461262 reported by
Michael Vogt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Snappy | Status tracked in Trunk | |||||
| 15.04 |
Fix Released
|
Undecided
|
John Lenton | |||
| Trunk |
Fix Released
|
Undecided
|
Michael Vogt | |||
Bug Description
Chippaca noticed that the quoting is broken for snappy login. This shouldn't be a big issue because the quoting is only for token_key, token_secret, consumer_key, consumer_secret (when using the plaintext signature method which we do) which is all ascii and does not need quoting. But we still want to fix it.
Related branches
lp:~mvo/snappy/snappy-oauth-quoting
- Michael Vogt (community): Approve
- John Lenton (community): Approve
-
Diff: 268 lines (+164/-22)6 files modifiedgen-coverage.sh (+2/-0)
oauth/oauth.go (+80/-0)
oauth/oauth_test.go (+69/-0)
snappy/auth.go (+2/-19)
snappy/auth_test.go (+9/-2)
snappy/snapp.go (+2/-1)
lp:~chipaca/snappy/fix-1461262
- Ricardo Salveti (community): Approve
-
Diff: 268 lines (+164/-22)6 files modifiedgen-coverage.sh (+2/-0)
oauth/oauth.go (+80/-0)
oauth/oauth_test.go (+69/-0)
snappy/auth.go (+2/-19)
snappy/auth_test.go (+9/-2)
snappy/snapp.go (+2/-1)
