Bug #1461251 “Stop using deprecated oslo_utils.timeutils.isotime...” : Bugs : OpenStack Identity (keystone)

Brant Knudson (blk-u) on 2015-06-02

Changed in keystone:
assignee:	nobody → Brant Knudson (blk-u)
importance:	Undecided → Critical

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-06-02: Fix proposed to keystone (master)

#1

Fix proposed to branch: master
Review: https://review.openstack.org/187751

Changed in keystone:
status:	New → In Progress

Revision history for this message

Dave Chen (wei-d-chen) wrote on 2015-06-03:

#2

This bug currently break the Jenkins, let's fix it sooner than later.

Revision history for this message

Dolph Mathews (dolph) wrote on 2015-06-03:

#3

Added oslo to this bug for unacceptably impacting at least keystone and heat, by not providing a viable alternative capable of maintaining backward compatibility with existing public APIs.

Keystone's solution is to stop using oslo.timeutils in this instance, and instead move the deprecated timeutils function into keystone's namespace:

https://review.openstack.org/#/c/187751/1/keystone/common/utils.py,unified

That said, Heat found the introduction of a API backward incompatibility to be acceptable:

https://review.openstack.org/#/c/187633/1/heat/tests/test_engine_api_utils.py,unified

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-06-03: Fix merged to keystone (master)

#4

Reviewed: https://review.openstack.org/187751
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=386054847e3434122a5070f2894908ff437d901e
Submitter: Jenkins
Branch: master

commit 386054847e3434122a5070f2894908ff437d901e
Author: Brant Knudson <email address hidden>
Date: Tue Jun 2 14:55:50 2015 -0500

Switch from deprecated isotime

oslo_utils.timeutils.isotime() is deprecated as of 1.6 so we need
to stop using it.

    The deprecation message says to use datetime.datetime.isoformat()
    instead, but the format of the string generated by isoformat isn't
    the same as the format of the string generated by isotime. The string
    is used in tokens and other public APIs and we can't change it
    without potentially breaking clients.

So the workaround is to copy the current implementation from
oslo_utils.timeutils.isotime() to keystone.common.utils.isotime().

Closes-Bug: 1461251

Change-Id: Icf821be8cd4ee7f52c1a3d89bfed302488c080f2

Changed in keystone:
status:	In Progress → Fix Committed

Brant Knudson (blk-u) on 2015-06-07

Changed in python-keystoneclient:
assignee:	nobody → Brant Knudson (blk-u)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-06-07: Fix proposed to python-keystoneclient (master)

#5

Fix proposed to branch: master
Review: https://review.openstack.org/189147

Changed in python-keystoneclient:
status:	New → In Progress

Doug Hellmann (doug-hellmann) on 2015-06-23

Changed in keystone:
milestone:	none → liberty-1
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-07-16: Fix merged to python-keystoneclient (master)

#6

Reviewed: https://review.openstack.org/189147
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=97c2c690d8983fd1d929a4eae3b0d62bbcb2cf6a
Submitter: Jenkins
Branch: master

commit 97c2c690d8983fd1d929a4eae3b0d62bbcb2cf6a
Author: Brant Knudson <email address hidden>
Date: Sun Jun 7 11:20:44 2015 -0500

Switch from deprecated isotime

oslo_utils.timeutils.isotime() is deprecated as of 1.6 so we need
to stop using it.

    The deprecation message says to use datetime.datetime.isoformat()
    instead, but the format of the string generated by isoformat isn't
    the same as the format of the string generated by isotime. The string
    is used in tokens and other public APIs and we can't change it
    without potentially breaking clients.

So the workaround is to copy the current implementation from
oslo_utils.timeutils.isotime() to keystone.common.utils.isotime().

Change-Id: I34b12b96de3ea21beaf935ed8a9f6bae2fe0d0bc
Closes-Bug: 1461251

Changed in python-keystoneclient:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-07-30: Fix proposed to python-keystoneclient (feature/keystoneauth_integration)

#7

Fix proposed to branch: feature/keystoneauth_integration
Review: https://review.openstack.org/207267

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-08-28: Fix merged to python-keystoneclient (feature/keystoneauth_integration)

#8

Download full text (22.7 KiB)

Reviewed: https://review.openstack.org/207267
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=4e498a54d0034b2ce5c87130f080ff580d241600
Submitter: Jenkins
Branch: feature/keystoneauth_integration

commit 51d9d123a8df79f6b84d196d41f1008f8d6033d4
Author: Brant Knudson <email address hidden>
Date: Wed Aug 5 12:28:30 2015 -0500

Deprecate openstack.common.apiclient

Deprecate the apiclient from oslo-incubator so we can get rid of
it.

bp deprecations

Change-Id: I1c761933816da03b6c625f14d0aac43f206e88d7

commit 16e834dd4597314d79cf4fb0bb98449e6552f804
Author: Brant Knudson <email address hidden>
Date: Wed Aug 5 11:17:34 2015 -0500

Move apiclient.base.Resource into keystoneclient

    keystoneclient is using apiclient.base and in order to properly
    deprecate and eventually get rid of apiclient we need to move the
    symbols that keystoneclient uses out of apiclient.

    This change moves apiclient.base.Resource into keystoneclient.base
    by merging apiclient.base.Resource into the existing
    keystoneclient.base.Resource. apiclient.base.Resource is now
    renaming keystoneclient.base.Resource for backwards-compatibility.

Change-Id: Id479711b7c9437aaf171def6976aab8b303ec56d

commit 26534dadb1d0be00b87b632a038839ab1c18cfe4
Author: Brant Knudson <email address hidden>
Date: Tue Aug 4 19:57:26 2015 -0500

oslo-incubator apiclient.exceptions to keystoneclient.exceptions

    Applications are using exceptions out of
    keystoneclient.openstack.common.apiclient.exceptions so it's part
    of the public interface. But since it's from oslo-incubator it's
    not considered stable. Since keystoneclient is all stable this
    creates bad situation.

    With this change, all the symbols out of apiclient.exceptions are
    moved into keystoneclient.exceptions rather than the other way
    around (keystoneclient.exceptions used to re-export all of
    apiclient.exceptions). Now we're in control of the
    apiclient.exceptions and keystoneclient.exceptions that
    applications are using.

Closes-Bug: 1481806
Change-Id: Ib3afa86b9d276f6a45d1ecd6f9157ee02ec8570d

commit eaa7ddd7443ca166f6646e808dcad959811d158b
Author: Brant Knudson <email address hidden>
Date: Sun Jul 26 06:53:58 2015 -0500

Proper deprecation for HTTPClient session and adapter properties

    HTTPClient's forwarded session and adapter properties weren't
    properly deprecated since the deprecations was only mentioned in
    the docstring. Proper deprecation requires use of warnings/
    debtcollector and documentation.

bp deprecations

Change-Id: Iea76d7bbc3bdeb13f7fdb097f13e007b4dd85c8d

commit 0c2fef51d2b90df088d30e9b6c5079caae7c6578
Author: Brant Knudson <email address hidden>
Date: Fri Jul 24 15:52:57 2015 -0500

Proper deprecation for HTTPClient.request methods

    HTTPClient.request and related methods weren't properly
    deprecated since they were only mentioned in the docstrings.
    Proper deprecation requires use of warnings/debtcollector and
    documentation.

Also, fixed places where the deprecated request m...

Reviewed:  https://review.openstack.org/207267
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=4e498a54d0034b2ce5c87130f080ff580d241600
Submitter: Jenkins
Branch:    feature/keystoneauth_integration

commit 51d9d123a8df79f6b84d196d41f1008f8d6033d4
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Wed Aug 5 12:28:30 2015 -0500

Deprecate openstack.common.apiclient
    
    Deprecate the apiclient from oslo-incubator so we can get rid of
    it.
    
    bp deprecations
    
    Change-Id: I1c761933816da03b6c625f14d0aac43f206e88d7

commit 16e834dd4597314d79cf4fb0bb98449e6552f804
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Wed Aug 5 11:17:34 2015 -0500

Move apiclient.base.Resource into keystoneclient
    
    keystoneclient is using apiclient.base and in order to properly
    deprecate and eventually get rid of apiclient we need to move the
    symbols that keystoneclient uses out of apiclient.
    
    This change moves apiclient.base.Resource into keystoneclient.base
    by merging apiclient.base.Resource into the existing
    keystoneclient.base.Resource. apiclient.base.Resource is now
    renaming keystoneclient.base.Resource for backwards-compatibility.
    
    Change-Id: Id479711b7c9437aaf171def6976aab8b303ec56d

commit 26534dadb1d0be00b87b632a038839ab1c18cfe4
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Tue Aug 4 19:57:26 2015 -0500

oslo-incubator apiclient.exceptions to keystoneclient.exceptions
    
    Applications are using exceptions out of
    keystoneclient.openstack.common.apiclient.exceptions so it's part
    of the public interface. But since it's from oslo-incubator it's
    not considered stable. Since keystoneclient is all stable this
    creates bad situation.
    
    With this change, all the symbols out of apiclient.exceptions are
    moved into keystoneclient.exceptions rather than the other way
    around (keystoneclient.exceptions used to re-export all of
    apiclient.exceptions). Now we're in control of the
    apiclient.exceptions and keystoneclient.exceptions that
    applications are using.
    
    Closes-Bug: 1481806
    Change-Id: Ib3afa86b9d276f6a45d1ecd6f9157ee02ec8570d

commit eaa7ddd7443ca166f6646e808dcad959811d158b
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Sun Jul 26 06:53:58 2015 -0500

Proper deprecation for HTTPClient session and adapter properties
    
    HTTPClient's forwarded session and adapter properties weren't
    properly deprecated since the deprecations was only mentioned in
    the docstring. Proper deprecation requires use of warnings/
    debtcollector and documentation.
    
    bp deprecations
    
    Change-Id: Iea76d7bbc3bdeb13f7fdb097f13e007b4dd85c8d

commit 0c2fef51d2b90df088d30e9b6c5079caae7c6578
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 15:52:57 2015 -0500

Proper deprecation for HTTPClient.request methods
    
    HTTPClient.request and related methods weren't properly
    deprecated since they were only mentioned in the docstrings.
    Proper deprecation requires use of warnings/debtcollector and
    documentation.
    
    Also, fixed places where the deprecated request method was called.
    
    bp deprecations
    
    Change-Id: I0a16933252937ca046793bb6eb2e5cc5da03c9ae

commit ada04acf4d60eafc0e31e6ac079ddb2c4f12e728
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 15:34:27 2015 -0500

Proper deprecation for HTTPClient.tenant_id|name
    
    HTTPClient tenant_id and tenant_name properties weren't properly
    deprecated since they were only mentioned in the docstring. Proper
    deprecation requires use of warnings/debtcollector and
    documentation.
    
    bp deprecations
    
    Change-Id: I3c2f87df14bc9f8ffd82b99919fd1048123d0669

commit 1721e01743324fc10630131d590659f565a3684d
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 15:06:00 2015 -0500

Proper deprecation for HTTPClient tenant_id, tenant_name parameters
    
    HTTPClient() tenant_id and tenant_name parameters weren't properly
    deprecated since they were only mentioned in the docstring. Proper
    deprecation requires use of warnings/debtcollector and documentation.
    
    Also fixed a bunch of places in the tests where tenant_id and
    tenant_name were still being used despite being deprecated.
    
    bp deprecations
    
    Change-Id: I9c4f596b8ff10aede6c417886638a942cb18044c

commit a9ef92a43f7d3cecd6a92d07fe7b4857d00eb2e4
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Tue Aug 4 00:48:54 2015 +0000

Updated from global requirements
    
    Change-Id: Idb9238ef74d67dc2bccf5ca49ada78507dfdf373

commit 22236fd763ed8d240b254ed54f892fb6fc0f454a
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Sun Aug 2 11:22:18 2015 -0500

Clarify setting socket_options
    
    There was a lot of code that would have no effect if kwargs already
    had socket_options set. To make the code clearer, only execute the
    code if it's going to have an effect.
    
    Change-Id: Ic42f5a0bac07113aff59d36d19293dc6d65cd58a

commit aa5738c23de6b88ff98ad649bef7b023d71a1b02
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Sun Aug 2 11:18:45 2015 -0500

Remove check for requests version
    
    requirements.txt has requests>=2.5.2, so requests version is always
    going to be >= 2.4.1 and there's no need to check it.
    
    Change-Id: I8069cfbd54ce716979bc991d137bd2e71790a1e4

commit 9e470a5d7757b97ef74a8c3ecdd95852221db450
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Wed Jul 29 03:50:34 2015 +0000

Updated from global requirements
    
    Change-Id: I08cdf12dad7fc99cddc55580ea9a99fefd79a399

commit 0b745909a66508b539c848e2d8101a56abadb69e
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 15:21:53 2015 -0500

Fix tests passing user, project, and token
    
    The tests were creating httpclient.HTTPClient() using username,
    token, and project, but if you pass a token then username and
    project are going to be ignored since there's no need to auth.
    
    Make the tests more understandable by removing the ignored and
    useless parameters.
    
    bp deprecations
    
    Change-Id: Ide3f4be4dd00db89f551d014876625cff296f6a7

commit 9f17732308c13264c3ea4c16771153f2e86369b9
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 14:52:12 2015 -0500

Proper deprecation for httpclient.request()
    
    httpclient.request() wasn't properly deprecated since it was only
    mentioned in a comment. Proper deprecation requires use of
    warnings/debtcollector and documentation.
    
    bp deprecations
    
    Change-Id: Id35d64a8b2d536c5de90e398b2a7680fa30881d6

commit fb28e1a2b80c21ff6a9728654b4d736add810ae1
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 14:45:36 2015 -0500

Proper deprecation for Dicover.raw_version_data unstable parameter
    
    Dicover.raw_version_data()'s unstable parameter wasn't properly
    deprecated since it was only mentioned in the docstring. Prope
     deprecation requires use of warnings/debtcollector and
    documentation.
    
    Also, fixed a place where the deprecated function could be used.
    
    bp deprecations
    
    Change-Id: I42dd7c1831bcfc3c637572eb112353b8760ed8d0

commit a303cbc0ece4a423e58a2fc704c4062b25ede29f
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 14:32:29 2015 -0500

Proper deprecation for Dicover.available_versions()
    
    Dicover.available_versions() wasn't properly deprecated since it
    was only mentioned in the docstring. Proper deprecation requires use
    of warnings/debtcollector and documentation.
    
    bp deprecations
    
    Change-Id: Ifbcedec1d464435ebb9bcec779fadac0dfb28909

commit 5547fe80b082035393b2bf1f59fd3a1a5c531817
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 14:25:05 2015 -0500

Proper deprecation for is_ans1_token
    
    is_ans1_token wasn't properly deprecated since it used LOG.warn
    rather than warnings/debtcollector. Proper deprecation requires use
    of warnings and documentation.
    
    bp deprecations
    
    Change-Id: I81be2844014745a5951ce91a336e9e9ecf4d5328

commit ce58b07eea29a43ee42655627e78820add16d1f5
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 14:21:37 2015 -0500

Proper deprecation for client.HTTPClient
    
    client.HTTPClient wasn't properly deprecated since all it had was
    a comment in the code. Proper deprecation requires use of warnings
    and documentation.
    
    bp deprecations
    
    Change-Id: I1c50c1441b23a79831e6e1df749084130e4b9af7

commit c5b03191b6714fed15bd88769c89e897257c337d
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 14:14:13 2015 -0500

Proper deprecation for Manager.api
    
    base.Manager's api property wasn't properly deprecated since all it
    had was documentation. Proper deprecation requires use of warnings
    and documentation.
    
    bp deprecations
    
    Change-Id: Ic5e218151e9b3f3b66f78729052680691d5ad582

commit fee5ba7432ff4b282aacbb8dafac948af2006f45
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 14:14:00 2015 -0500

Stop using Manager.api
    
    base.Manager's api is documented as being deprecated, but there was
    still code using it. Deprecated function must not be used.
    
    bp deprecations
    
    Change-Id: I58678626b55f3cd11f4fdbcddbe4cc9461692fbf

commit b1496abbb77360672d1d94e689513daeeb3cafd0
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 13:57:12 2015 -0500

Proper deprecation for BaseIdentityPlugin trust_id property
    
    BaseIdentityPlugin's trust_id property wasn't properly deprecated
    since all it had was a comment in the code. Proper deprecation
    requires use of warnings and documentation.
    
    Where the plugins already provide their own trust_id, the
    property needs to be un-deprecated.
    
    bp deprecations
    
    Change-Id: I15d4e019bfc5542990120ba39be65ad83cf040d5

commit 799e1faa505ac0c62d6db76ad68cdbb2d7148888
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 13:16:00 2015 -0500

Proper deprecation for BaseIdentityPlugin username, password, token_id properties
    
    BaseIdentityPlugin's username, password, and token_id properties
    weren't properly deprecated since all they had was a comment in
    the code. Proper deprecation requires use of warnings and
    documentation.
    
    Where the plugins already provide their own properties, the
    properties need to be un-deprecated.
    
    bp deprecations
    
    Change-Id: Ic9fce89b8544d8c01f16e8f9c2f9dd2659d03c18

commit 85b32fcb9d1df1362209c2902768a4de013004cb
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 11:15:34 2015 -0500

Proper deprecations for modules
    
    Use debtcollector and update docs for deprecating the apiclient,
    apiclient.exceptions, middleware.s3_token, and v2_0.shell modules.
    
    bp deprecations
    
    Change-Id: I84e8eac39a209210542f19de08d4c3de15a9dcac

commit 6950527f09f759c44ef145bde71d600a4066daf7
Author: Jamie Lennox <jamielennox@redhat.com>
Date:   Sat Mar 28 15:03:19 2015 +1100

Use UUID values in v3 test fixtures
    
    The fixtures will automatically stub UUID values for required token
    fields, so we can check for those returned values rather than specify
    fixed string values.
    
    Change-Id: I8a6cc675c6c8ee14772a38d8fc38475885ebc605

commit 1a2ccb001bdbb09a3b66c6aca651ce71e62734d8
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 10:51:49 2015 -0500

Proper deprecation for AccessInfo management_url property
    
    AccessInfo's management_url parameter wasn't properly deprecated
    since all it had was a comment in the code. Proper deprecation
    requires use of warnings and documentation.
    
    bp deprecations
    
    Change-Id: I0ee07c5adc6a7c91f8b23b291eea76f4ae7b3b89

commit 6d82f1f17ca99b4e318b6c5bfa24b6dc507ba497
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 10:12:12 2015 -0500

Proper deprecation for AccessInfo auth_url property
    
    Properly deprecate accessing AccessInfo's auth_url parameter.
    
    bp deprecations
    
    Change-Id: I3824904f517434b507587cf73d4389b72f73f22b

commit 66fd1eb7484f92a7d3daa468be8c47910ba79216
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 10:11:57 2015 -0500

Stop using deprecated AccessInfo.auth_url and management_url
    
    The comments for the auth_url and management_url properties say
    that they're deprecated and to use the service catalog, but
    internal code was using the deprecated function. The
    code needs to be changed to use non-deprecated function.
    
    bp deprecations
    
    Change-Id: I6ada821fe305650d22e58a55192332f0f4986537

commit f782ee853c49dda7f86055192a01c75269e26aff
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 09:10:49 2015 -0500

Proper deprecation for AccessInfo scoped property
    
    Properly deprecate constructing AccessInfo's scoped parameter.
    
    bp deprecations
    
    Change-Id: I8f81c75eb8e758feb9d4c62ce7f041957562e766

commit 8d65259cb887c0a4f9c26d3994aef131633c5189
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 08:15:46 2015 -0500

Proper deprecation for AccessInfo region_name parameter
    
    Properly deprecate constructing AccessInfo with region_name
    parameter.
    
    bp deprecations
    
    Change-Id: Ic5f48a4f5354beb8be68c2fd788bf0a974501917

commit 610844d06db5b2af93c0747a7690c44d3724510b
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Fri Jul 24 08:05:13 2015 -0500

Deprecations fixture support calling deprecated function
    
    Sometimes a test is expected to call deprecated function, such as
    when testing that deprecated function still works. Now the test can
    tell the Deprecations fixture that it's calling deprecated function.
    
    Change-Id: Ic7486b74f681989eb5110dfeaf8dae0e5d7ae50e

commit c6b14f94c5021452796d7bd151c2c98ae983afdd
Author: Ian Cordasco <graffatcolmingov@gmail.com>
Date:   Wed Jul 22 14:53:32 2015 -0500

Set reasonable defaults for TCP Keep-Alive
    
    Previously we simply turned on TCP Keep-Alive which relied on
    per-distribution, per-operating system defaults for keep-alive options.
    Here we set reasonable defaults since long running processes can get
    stuck for hours on end by using system defaults. This also adds comments
    around the options to explain why they're being set.
    
    Closes-bug: 1477275
    Related-bug: 1323862
    Change-Id: Ibd53ae2d4d2455db0ebc9951e5c764befc57850f

commit bb6463e20fce83886205f82b320db739ce6c7311
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Thu Jul 23 07:44:44 2015 +0000

Updated from global requirements
    
    Change-Id: I772ee10288955bae1f3f3707eb1b34573df03e60

commit 0d5415e9e979a5377034352662dcfe8edc086fae
Author: Boris Bobrov <bbobrov@mirantis.com>
Date:   Thu Jul 23 00:34:43 2015 +0300

Remove unused time_patcher
    
    There is no reason to patch time now, tests succeed without it
    
    Change-Id: I3cf3017b5f86bae35276037c60cfec8dc3be20ae

commit 7d5d8b343232ee5faf4de3381024095619335929
Author: Boris Bobrov <bbobrov@mirantis.com>
Date:   Wed Jul 22 18:52:49 2015 +0300

Make OAuth testcase use actual request headers
    
    OAuth test verifies that access_token manager's methods make requests with
    certain parameters. It is supposed to use values from mocked http handler
    and compare them with referential values acquired from oauth client.
    
    But instead of using values from mocked handler, it used the values from
    oauth client and compared them with values from the client acquired using
    attributes, basically testing oauthlib and not access_token manager's
    methods.
    
    Make the test compare correct values and remove check of timestamp,
    which was useless because it is always mocked in tests and not provided in
    actual requests.
    
    As a consequence, use of get_oauth_params, which changed in oauthlib
    1.0 and blocked the gate, was removed.
    
    Closes-Bug: 1477177
    Closes-Bug: 1477247
    Change-Id: I5e049163f84fde5827104fd4a6441222eb08468f

commit 98326c72f732481d73f2941827a1dae75c61388b
Author: Dolph Mathews <dolph.mathews@gmail.com>
Date:   Wed May 13 16:38:44 2015 +0000

Prevent attempts to "filter" list() calls by globally unique IDs
    
    This use case isn't covered by our current APIs:
    
      GET /entities?id={entity_id}
    
    Because we have a dedicated API for that:
    
      GET /entities/{entity_id}
    
    But our list() methods generally support **kwargs, which are passed as
    query parameters to keystone. When an 'id' is passed to keystone as a
    query parameter, keystone rightly ignores it and returns an unfiltered
    collection.
    
    This change raises a client-side TypeError (as you'd expect when you try
    to pass a keyword argument that a function isn't expecting), and
    includes a helpful suggestion to try calling get() instead.
    
    Change-Id: I100b69bbf571ad6de49ccc5ad1099c20b877d13d
    Closes-Bug: 1452298

commit a4584c4ba7fa62c923d7da883e1cf8080e1275ad
Author: Jamie Lennox <jamielennox@redhat.com>
Date:   Tue Jun 23 11:32:11 2015 +0800

Add get_token_data to token CRUD
    
    We already have the validate method that returns an AccessInfo object.
    For auth_token middleware it would be simpler if the client returned
    simply the token data so it presented the same way as other sources of
    token data.
    
    It would also help with the keystoneauth transition in auth_token as we
    could bypass the keystoneclient.AccessInfo objects.
    
    Closes-Bug: #1475041
    Change-Id: Ifbe7a7004937d910739c325cc04ae7264a4498e0

commit 2f90bb68ac1d98f7d14f23f1f2dde7c88346daf5
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Wed Jul 15 01:37:25 2015 +0000

Updated from global requirements
    
    Change-Id: I25bef4f42fc42765b493f17295add61ba3353803

commit 3668d9cae2f620b5414c2c181cbd3adccd95e6e9
Author: Eric Brown <browne@vmware.com>
Date:   Mon Jul 13 04:53:17 2015 -0700

py34 not py33 is tested and supported
    
    The setup.cfg refers to Programming Language of Python 3.3 whereas
    jenkins is setup only to test Python 3.4. This patch updates setup.cfg
    and removes py33 from tox.ini.
    
    TrivialFix
    
    Change-Id: I1bc7fae6481c4fef71746ed1c144af37445a81ac

commit d3b97553955dfa970228649c7a25c32a26dd44b9
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Sun Jul 12 15:22:13 2015 +0000

Updated from global requirements
    
    Change-Id: I584fe4bee5a4785d6c5862fe8ae417481cc04d36

commit 4034366b51244547e6b589160f8db015bb72be37
Author: David Stanek <dstanek@dstanek.com>
Date:   Tue Jul 7 21:53:22 2015 +0000

Fixes modules index generated by Sphinx
    
    Sphinx was always using (k)eystoneclient for the prefix so the index
    wasn't very useful.
    
    Change-Id: I9f883e1005874b5f5019f9030b94174a2169ed77

commit c503c29f930638b31c99ed4827ec8a3dd0bde8fe
Author: OpenStack Proposal Bot <openstack-infra@lists.openstack.org>
Date:   Thu Jul 2 18:57:20 2015 +0000

Updated from global requirements
    
    Change-Id: I55424466d38369fdbd12852255fe94a0e2676c0a

commit 31f326dab688cab0274b3326ca3a5d3c6cf547fc
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Mon Jun 8 20:36:02 2015 -0500

Unit tests catch deprecated function usage
    
    Rather than continue to call deprecated functions without knowing
    it, have the unit tests fail when deprecated function is used.
    
    This will ensure that code isn't added that calls deprecated
    functions.
    
    Change-Id: If9f58e30a08a88778e4ae3fc01399ad90997e812

commit 225832f5913e12f8c86c429193e6ed4531dcc101
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Mon Jun 29 15:46:35 2015 -0500

Switch from deprecated oslo_utils.timeutils.strtime
    
    The oslo_utils.timeutils.strtime function is deprecated as of
    oslo_utils 1.7.
    
     DeprecationWarning: Using function/method
     'oslo_utils.timeutils.strtime()' is deprecated in version '1.6'
     and will be removed in a future version: use either
     datetime.datetime.isoformat() or datetime.datetime.strftime()
     instead
    
    Closes-Bug: 1469867
    Change-Id: I97897728703547414a621b6687989cff07e01b3e

commit 97c2c690d8983fd1d929a4eae3b0d62bbcb2cf6a
Author: Brant Knudson <bknudson@us.ibm.com>
Date:   Sun Jun 7 11:20:44 2015 -0500

Switch from deprecated isotime
    
    oslo_utils.timeutils.isotime() is deprecated as of 1.6 so we need
    to stop using it.
    
    The deprecation message says to use datetime.datetime.isoformat()
    instead, but the format of the string generated by isoformat isn't
    the same as the format of the string generated by isotime. The string
    is used in tokens and other public APIs and we can't change it
    without potentially breaking clients.
    
    So the workaround is to copy the current implementation from
    oslo_utils.timeutils.isotime() to keystone.common.utils.isotime().
    
    Change-Id: I34b12b96de3ea21beaf935ed8a9f6bae2fe0d0bc
    Closes-Bug: 1461251

commit ef0f2677c2efbba709859785415ec1cc1bf583cc
Author: Steve Martinelli <stevemar@ca.ibm.com>
Date:   Sun Jun 28 05:47:32 2015 +0000

Remove keystoneclient CLI references in README
    
    The content of this file determines what it shown in pypi, which
    many end users see. Highlighting our soon to be deprecated CLI
    as a feature for python-keystoneclient seems illogical.
    
    Change-Id: Ia756353f0c58fac245be2e2daaa63ca7831478d1

commit 20db11f8bdf0bc9b3ce23c21bf67753ca5690372
Author: Steve Martinelli <stevemar@ca.ibm.com>
Date:   Wed Apr 29 12:27:30 2015 -0400

Update README.rst and remove ancient reference
    
    There's no need to give a shout out to a project that is going on
    6 years old and has been deprecated.
    
    Also provide more valuable links, such as where we track bugs, our
    source code, and docs.
    
    Change-Id: I9ea5ca83366f9dc0b2732c5db017257a1250fc05

commit a951023f7cfbebebaafd89c84d301dc7efe8fb76
Author: Steve Martinelli <stevemar@ca.ibm.com>
Date:   Sun Jun 28 05:49:46 2015 +0000

Remove unused images from docs
    
    These images were used to show how auth_token worked, these images
    are now shown on keystonemiddleware's docs, so lets remove them
    from here.
    
    Change-Id: I2e882d3580737ee091a5e05cf98b0d652f3fefcb

commit 831ba037b0ba2077e168cb33976c78e565aece88
Author: Jamie Lennox <jamielennox@redhat.com>
Date:   Mon Mar 30 17:16:25 2015 +1100

Support /auth routes for list projects and domains
    
    The /auth routes are the preferred mechanism for listing the projects
    and domains that the current token can be authenticated to as they
    supports both federated and regular tokens.
    
    Expose these routes via the client so that they can be consumed.
    
    Change-Id: I9724a648ebd9d21edf8ffcc64f4cdb897a99101c

Doug Hellmann (doug-hellmann) on 2015-09-04

Changed in python-keystoneclient:
milestone:	none → 1.7.0
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-10-15

Changed in keystone:
milestone:	liberty-1 → 8.0.0

OpenStack Infra (hudson-openstack) on 2016-11-07

Changed in cloudkitty:
assignee:	nobody → Tuan (tuanla)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-03: Fix merged to cloudkitty (master)

#9

Reviewed: https://review.openstack.org/394226
Committed: https://git.openstack.org/cgit/openstack/cloudkitty/commit/?id=932b5feb7c489bda748c8bc50efa7fa9bbff21ba
Submitter: Jenkins
Branch: master

commit 932b5feb7c489bda748c8bc50efa7fa9bbff21ba
Author: Luong Anh Tuan <email address hidden>
Date: Mon Nov 7 09:01:58 2016 +0700

Replace oslo_utils.timeutils.isotime

    Function 'oslo_utils.timeutils.isotime()' is deprecated in version '1.6'
    and will be removed in a future version. We cant't use
    datetime.datetime.isoformat() instead. Because the format of the string
    generated by isoformat isn't the same as the format of the string
    generated by isotime. The string is used in tokens and other public
    APIs and we can't change it without potentially breaking clients.

So the workaround is to copy the current implementation from
oslo_utils.timeutils.isotime() to utils.py

For more informations:
http://docs.openstack.org/developer/oslo.utils/api/timeutils.html#oslo_utils.timeutils.isotime

Change-Id: Ib384ae8130dcc6cbd47a837d11ca171ce02ef29e
Closes-Bug: #1461251

Changed in cloudkitty:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-02: Fix included in openstack/cloudkitty 5.0.0

#10

This issue was fixed in the openstack/cloudkitty 5.0.0 release.

Chenghui Yu (chenghuiyu) on 2017-09-06

Changed in oslo.utils:
assignee:	nobody → Chenghui Yu (chenghuiyu)
status:	New → In Progress

Chenghui Yu (chenghuiyu) on 2017-09-07

Changed in gce-api:
status:	New → In Progress
assignee:	nobody → Chenghui Yu (chenghuiyu)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-11: Fix proposed to gce-api (master)

#11

Fix proposed to branch: master
Review: https://review.openstack.org/502371

Chenghui Yu (chenghuiyu) on 2017-09-11

Changed in ec2-api:
assignee:	nobody → Chenghui Yu (chenghuiyu)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-11: Fix proposed to ec2-api (master)

#12

Fix proposed to branch: master
Review: https://review.openstack.org/502373

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-04-08: Change abandoned on ec2-api (master)

#13

Change abandoned by Chenghui Yu (<email address hidden>) on branch: master
Review: https://review.openstack.org/502373

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-30: Fix merged to ec2-api (master)

#14

Reviewed: https://review.openstack.org/579145
Committed: https://git.openstack.org/cgit/openstack/ec2-api/commit/?id=c65cb663de5d1cfb239bbf32610f0f7a71c7e170
Submitter: Zuul
Branch: master

commit c65cb663de5d1cfb239bbf32610f0f7a71c7e170
Author: chenghuiyu <email address hidden>
Date: Mon Sep 11 10:48:48 2017 +0800

Fix usage of isotime

    The commit I34b12b96de3ea21beaf935ed8a9f6bae2fe0d0bc and
    Ib384ae8130dcc6cbd47a837d11ca171ce02ef29e introduced the
    deprecated oslo_utils.timeutils.isotime() is deprecated
    as of 1.6.

    The deprecation message says to use the datetime.datetime.isoformat()
    instead, but the format of the string generated by isoformat isn't
    the same as the format of the string generated by isotime. The string
    is used in tokens and other public APIs and we can't change it
    without potentially breaking clients.

So the workaround is to copy the current implementation from
oslo_utils.timeutils.isotime() to ec2api.api.ec2utils.

For more informations:
https://docs.openstack.org/oslo.utils/latest/reference/timeutils.html

Change-Id: Id62fb53264b04a7ea6ae3035a129353c5cfa040a
Closes-Bug: #1461251

Changed in ec2-api:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-07-30: Fix included in openstack/ec2-api 7.0.0

#15

This issue was fixed in the openstack/ec2-api 7.0.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-03-09: Change abandoned on oslo.utils (master)

#16

Change abandoned by "Hervé Beraud <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/oslo.utils/+/816700

Revision history for this message

Takashi Kajinami (kajinamit) wrote on 2024-02-11:

#17

The said interface was removed by https://review.opendev.org/c/openstack/oslo.utils/+/842344

Changed in oslo.utils:
status:	In Progress → Fix Released
assignee:	Chenghui Yu (chenghuiyu) → nobody

OpenStack Identity (keystone)

Stop using deprecated oslo_utils.timeutils.isotime

Bug Description

Other bug subscribers

Remote bug watches

	Status	Importance	Assigned to	Milestone
OpenStack Identity (keystone)	Fix Released	Critical	Brant Knudson	OpenStack Identity (keystone) 8.0.0 "liberty"
cloudkitty	Fix Released	Undecided	Tuan
ec2-api	Fix Released	Undecided	Chenghui Yu
gce-api	In Progress	Undecided	Chenghui Yu
oslo.utils	Fix Released	Undecided	Unassigned
python-keystoneclient	Fix Released	Undecided	Brant Knudson	python-keystoneclient 1.7.0 "1.7.0"