[1.8] PhysicalBlockDevice endpoint is incorrect for 1.9
Bug #1460643 reported by
Blake Rouse
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Blake Rouse | ||
Bug Description
The PhysicalBlockDevice API for add_tag and remove_tag would be better as just the BlockDevice API as this would match the coming work in 1.9 for storage.
We should make this change in 1.8 before it is released that way we don't need to maintain compatibility. It makes more since to have add_tag and remove_tag on the BlockDevice API anyway, allowing users to tag virtual and physical block devices. Even though in 1.8 virtual block devices are not used or created yet.
Related branches
lp:~blake-rouse/maas/fix-1460643
- Gavin Panella (community): Approve
-
Diff: 175 lines (+33/-35)3 files modifiedsrc/maasserver/api/blockdevices.py (+14/-16)
src/maasserver/api/tests/test_blockdevice.py (+14/-14)
src/maasserver/urls_api.py (+5/-5)
| Changed in maas: | |
| milestone: | none → 1.8.0 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
