Merlin

No need to use disableDefaultClickBehaviour

Bug #1459342 reported by Timur Sufiev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Merlin
Fix Committed
Wishlist
Vlad Okhrimenko

Bug Description

According to https://code.angularjs.org/1.3.15/docs/api/ng/directive/a if href="", the default click behavior is automatically disabled, so we could clean up the directives code a bit.

Revision history for this message
Vlad Okhrimenko (vokhrimenko) wrote :

https://review.openstack.org/#/c/190587/

Changed in merlin:
assignee: nobody → Vlad Okhrimenko (vokhrimenko)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to merlin (master)

Reviewed: https://review.openstack.org/190587
Committed: https://git.openstack.org/cgit/stackforge/merlin/commit/?id=7c09eb5fb5d8cb2dcc84148fe8d0c53b16dc6d85
Submitter: Jenkins
Branch: master

commit 7c09eb5fb5d8cb2dcc84148fe8d0c53b16dc6d85
Author: Vlad Okhrimenko <email address hidden>
Date: Thu Jun 11 14:15:26 2015 +0300

    No need to use disableDefaultClickBehaviour

    removed `#` from `href-tag`. Fixed scroll to top.

    Co-Authored-By: Timur Sufiev <email address hidden>
    Change-Id: I04bb343b0a4365c437d0f4625cb7a7c3ed7dc740
    closes-bug: #1459342
    closes-bug: #1448546

Changed in merlin:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.