Launchpad itself

Can't delete Git repositories

Bug #1456583 reported by Colin Watson
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Colin Watson

Bug Description

Git repository deletion isn't implemented yet.

Tags: feature git qa-ok

Related branches

lp:~cjwatson/launchpad/git-repository-delete
William Grant: Approve (code)
Diff: 1203 lines (+760/-36)
14 files modified
database/schema/security.cfg (+1/-0)
lib/lp/code/configure.zcml (+12/-1)
lib/lp/code/errors.py (+11/-0)
lib/lp/code/githosting.py (+16/-1)
lib/lp/code/interfaces/branch.py (+2/-8)
lib/lp/code/interfaces/gitjob.py (+25/-1)
lib/lp/code/interfaces/gitrepository.py (+39/-2)
lib/lp/code/model/branch.py (+0/-4)
lib/lp/code/model/gitjob.py (+54/-2)
lib/lp/code/model/gitrepository.py (+194/-3)
lib/lp/code/model/tests/test_gitjob.py (+68/-8)
lib/lp/code/model/tests/test_gitrepository.py (+319/-1)
lib/lp/services/config/schema-lazr.conf (+4/-0)
lib/lp/testing/factory.py (+15/-5)
lp:~cjwatson/launchpad/git-repository-delete-ui
William Grant: Approve (code)
Diff: 305 lines (+216/-2)
4 files modified
lib/lp/code/browser/configure.zcml (+8/-1)
lib/lp/code/browser/gitrepository.py (+93/-0)
lib/lp/code/browser/tests/test_gitrepository.py (+65/-1)
lib/lp/code/templates/gitrepository-delete.pt (+50/-0)
lp:~cjwatson/launchpad/git-repository-delete-access
William Grant: Approve (code)
Diff: 53 lines (+25/-0)
2 files modified
lib/lp/code/model/gitrepository.py (+5/-0)
lib/lp/code/model/tests/test_gitrepository.py (+20/-0)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r17520 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17520) is part of this bug's fix.

tags: added: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17522 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17522>.

Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Colin Watson (cjwatson) wrote :

Trying this on qastaging is resulting in:

IntegrityError: update or delete on table "gitrepository" violates foreign key constraint "accessartifact_gitrepository_fkey" on table "accessartifact"
DETAIL: Key (id)=(39) is still referenced from table "accessartifact".

That's probably just because I tried it with a proprietary repository, but I want to look into this before we deploy it.

Colin Watson (cjwatson)
tags: added: qa-bad
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17523 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17523>.

tags: added: qa-needstesting
removed: qa-bad
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Colin Watson (cjwatson) wrote :

We need to get the most recent DB patch applied to qastaging before we can test this.

Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.