Rescue dialog: some issues

Problems #2 and #3 are not problems! You clicked cancel, so of course it didn't update anything. When you cancel, it behaves exactly as if that dialog never appeared, eeschema updates the symbols to the new ones exactly as it used to.

#1 is an issues though. It's been working fine for me. Any chance you can share that project with me?

Wait - #1 isn't an issue either! It says "instances of this symbol". You have to click on the resistor in the first list to get resistors in the second list.

Well, it could be a design flaw, if people think I should change that behavior. But it's not a /bug/, per se.

Understood #1 -- it wasn't immediately obvious to me, but that is because I didn't read the dialog properly.

#2 is more of a wishlist item with the component update. If I ever cancel the rescue dialog, I need to be aware that my schematic is likely to be broken in a lot of places, and there needs to be an easy way to find these.

#3 is a bit of a problem, because the schematic did change -- after all, the components have been updated. The next time I reopen the schematic, I get the rescue dialog again.

That's the original behavior!

#2. Perhaps I can edit the description text at the top? The fact that the schematic was going to be broken should have been obvious, that's the whole point of the dialog! As for a way to find them - run ERC.

#3. No, the schematic didn't change! Try saving it and then diffing it against the original - not a single thing will change. The components are just being rendered out of the libraries, which *have* changed. That's what happens when you press cancel - *nothing*.

I'm going to look into patching #1 - it would have been more obvious if the first symbol in the list were actually selected, so you could see that the bottom list was based on that selection.

Hey Wayne, I can't remember - is the new library format supposed to hit before or after 5.0?

If before, I'm going to wontfix this due to priorities - the rescue dialog should be pointless after the new format is out, and I don't think there's much point in putting significant effort into the 4.0 branch beyond real bugfixes. If the new format won't be out until 6.0 I'll try to have this fixed targeting 5.0.

On 3/26/2017 7:04 PM, Chris Pavlina wrote:
> Hey Wayne, I can't remember - is the new library format supposed to hit
> before or after 5.0?

After. I'm just not going to have it ready for 5.0. The symbol library
table is going to be disruptive enough. The symbol library table code
should help to minimize the need for the rescuer but it wont completely
eliminate the need for it. There will be corner cases where the symbol
library table remapping algo falls short (mainly when someone breaks
their symbol library list) so I may still have to rescue missing symbols
into a library and map them that way.

>
> If before, I'm going to wontfix this due to priorities - the rescue
> dialog should be pointless after the new format is out, and I don't
> think there's much point in putting significant effort into the 4.0
> branch beyond real bugfixes. If the new format won't be out until 6.0
> I'll try to have this fixed targeting 5.0.
>

Fixed in revision feba091594bc81a97edcaf3cb628441fd91d4433
https://git.launchpad.net/kicad/patch/?id=feba091594bc81a97edcaf3cb628441fd91d4433

Wayne, mind if I push this commit to 4.0?

Please do since it effects the 4.0 branch. Thanks!

On 3/27/2017 8:45 AM, Chris Pavlina wrote:
> Wayne, mind if I push this commit to 4.0?
>