grub-core/fs/zfs/zfs.c:1126: feature missing in check_pool_label:com.delphix:hole_birth

Bug #1451476 reported by Lars
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
grub2 (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Need support for zpool feature feature@hole_birth.

The grub-probe in utopic/vivid is not able to boot a zpool which hast the feature@hole_birth enabled.

I had to build grub from git://git.savannah.gnu.org/grub.git to get my Ubuntu up and running again.
Could you please add the missing patches to grub to make it aware of feature@hole_birth?

Kind regards,
   Lars

PS: See also https://github.com/zfsonlinux/grub/issues/19

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

This should be fairly straightforward, when we're at the point of updating grub2 in debian/ubuntu then the change will be included. This will make that feature available in the development release (Wily Werewolf).

From that point, we can test and provided that tests are fine and the changes are sufficiently isolated; we could consider a SRU for it.

Looks to me like the patch should be just http://git.savannah.gnu.org/cgit/grub.git/commit/?id=a1007c6af296172c788f3346ff3ad30b9020f723, is that correct?

To speed things up a bit with the "paperwork" to providing such updates, could you also follow https://wiki.ubuntu.com/StableReleaseUpdates#Procedure to update the description for the bug to have the Impact, Test Case, Regression Potential information?

Thanks!

Changed in grub2 (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Lars (lollypop) wrote :

[Impact]
Grub is not able to boot the zpool and grub-probe is not able to detect the rootfs as zfs.

[Test Case]
If you enable the feature like this:
# zpool set feature@hole_birth=enabled <rootpool>

[Regression Potential]
I think the regression potential is low, because the new feature is added and will not be removed from upstream.

[Other Info]
Yes, Mathieu, I think it is just the patch you wrote:
 http://git.savannah.gnu.org/cgit/grub.git/commit/?id=a1007c6af296172c788f3346ff3ad30b9020f723

Thank you for your fast response!
   Lars

Revision history for this message
Richard Laager (rlaager) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package grub2 - 2.02~beta2-35

---------------
grub2 (2.02~beta2-35) unstable; urgency=medium

  * Apply the arm64 -mpc-relative-literal-loads workaround in configure
    rather than in debian/rules, to cope with toolchains that don't have the
    relevant patch applied.

 -- Colin Watson <email address hidden> Fri, 22 Jan 2016 11:02:10 +0000

Changed in grub2 (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.