Capomastro

Auto-tracking state is not saved when editing a project

Bug #1449241 reported by Caio Begotti on 2015-04-27

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Capomastro	Fix Released	Medium	Caio Begotti	Capomastro 2015-05 "may-2015"

Bug Description

Just noticed when you check auto-tracking at the project edit view its state is not really saved? I mean, it's probably saved but it's not restored when you leave then come back to the edit view (it's now wrongly unchecked). I'm not sure yet if it's just an UI problem if its value is not being passed on, which may cause problems with the builds IDs counts, which I'll report in another bug.

Bonus: have a better description of the checkbox in the UI

See original description

Related branches

lp:~caio1982/capomastro/autotracking-1449241

Merged into lp:capomastro at revision 191

Daniel Manrique (community): Approve on 2015-05-04

Caio Begotti (caio1982) on 2015-04-27

description:

updated

Revision history for this message

Daniel Manrique (roadmr) wrote on 2015-04-28:

OK, I confirmed this. To reproduce:

- Create a project. Select any set of dependencies, check "auto track" and create it.
- In the project detail page, confirm that the "auto-track" column says "yes" for your selected deps.
- Click "Edit project". Notice the auto-track checkbox is unchecked.
- Edit something unrelated like the description. Leave "auto-track" alone. Click Submit.

Expected result
- In the project detail page, the dependencies' auto-track column says "yes"

Actual result
- In the project detail page, the dependencies' auto-track column says "No"

Revision history for this message

Daniel Manrique (roadmr) wrote on 2015-04-28:

in projects/forms.py, the ProjectForm declares the auto_track boolean field but I don't see it being initialized anywhere.

Also, note that auto-tracking is set per dependency; that is, a project could auto-track dependency A but not auto-track dependency B (even though it can depend on both). So auto_track is actually an element in the intermediate ProjectDependency model.

So it's kinda hard to initialize auto_track. Clearly, if all ProjectDependency for this project are set to auto_track, we ought to set the tick mark to checked, and if none are set, then we set the tick mark to not checked. But if some are and some aren't, what should we do?

I don't think the capomastro user-facing UI allows setting autotrack independently for each dependency for a project, so we should NOT encounter the middle case.

I'm attaching a partial patch which fixes the functional part of this bug. What's missing? tests!! (Just didn't have time to do them). I'll set to triaged.

Revision history for this message

Daniel Manrique (roadmr) wrote on 2015-04-28:

1449241.patch Edit (978 bytes, text/plain)

Changed in capomastro:
status:	New → Triaged
importance:	Undecided → Medium
milestone:	none → 2015-05

Revision history for this message

Daniel Manrique (roadmr) wrote on 2015-04-28:

1449241.patch Edit (980 bytes, text/plain)

Wow, I think this second patch may be better, it queries on a non-indexed field but given the size of dependency lists for a project this should not be an issue.

Caio Begotti (caio1982) on 2015-05-04