Enable --ignore-errors flag please

Bug #1448249 reported by David Coppit
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Duplicity
Fix Released
Medium
Unassigned

Bug Description

If I want to apply a patch using a different system than the one on which it was created, rdiffdir fails while attempting to set the user and group both to "0".

The code is already guarded by a function that can optionally make this failure non-fatal. Below is a patch to enable a user-level flag to set globals.ignore_errors.

--- /usr/bin/rdiffdir 2015-03-06 23:50:14.000000000 +0000
+++ rdiffdir.new 2015-04-24 17:27:59.608000880 +0000
@@ -65,7 +65,7 @@
                                        "exclude-regexp=", "include=", "include-filelist=",
                                        "include-filelist-stdin", "include-globbing-filelist",
                                        "include-regexp=", "max-blocksize", "null-separator",
- "verbosity=", "write-sig-to="])
+ "verbosity=", "write-sig-to=", "ignore-errors"])
     except getopt.error, e:
         command_line_error("Bad command line option: %s" % (str(e),))

@@ -100,6 +100,8 @@
             log.setverbosity(int(arg))
         elif opt == "--write-sig-to" or opt == "--write-signature-to":
             sig_fileobj = get_fileobj(arg, "wb")
+ elif opt == "--ignore-errors":
+ globals.ignore_errors = 1
         else:
             command_line_error("Unknown option %s" % opt)

Revision history for this message
David Coppit (coppit) wrote :

The failure in setting the uid & gid was apparently due to bug 1449151. After patching, these operations completed without error.

This might still be a good feature to have though, as there might be other causes for failures in setting the attributes.

Changed in duplicity:
importance: Undecided → Medium
milestone: none → 0.7.03
status: New → Fix Committed
Changed in duplicity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.