gstreamer 0.10 apps prematurely stop parsing some flac files

Bug #1440440 reported by Forest
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gst-plugins-good0.10 (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Gstreamer 0.10 stops processing certain flac files before their end is reached. When it happens, no error condition is reported. It fails silently, as if the file was truncated.

This affects all applications that use gstreamer0.10-plugins-good, including clementine, exaile, soundconverter, and many others.

Upstream git branch 0.10 has had patches since 2012 that seem to fix the problem, but they have not yet made it into an official 0.10.x release. The relevant changesets are:

5881603 flacparse: avoid indefinite extended search for frame end if possible
440d703 flacparse: perform additional frame crc check if applicable
32cddf6 flacparse: avoid some more frame misparsing by additional header sanity check

The fixes are present in gstreamer 1.0, but applications that still depend on 0.10 (either directly or through python-gst) remain broken. This seems like a good reason to apply the fixes to 0.10.

Tags: patch
Revision history for this message
Forest (foresto) wrote :
Revision history for this message
Forest (foresto) wrote :
Revision history for this message
Forest (foresto) wrote :
Revision history for this message
Forest (foresto) wrote :

I have attached 3 upstream patches to fix the premature eos on some flac files:

0010-flacparse-avoid-indefinite-search-for-frame-end.patch
0011-flacparse-additional-frame-crc-check.patch
0012-flacparse-additional-header-sanity-check.patch

These are suitable for adding to the debian/patches directory (and series file) of gst-plugins-good0.10-0.10.31.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "0010-flacparse-avoid-indefinite-search-for-frame-end.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, do you have a reference to an upstream bug or an example where it's an issue currently in Ubuntu?

Changed in gst-plugins-good0.10 (Ubuntu):
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Forest (foresto) wrote :

All I have is a couple of files that trigger the bug. Unfortunately, I don't have the rights to post them publicly, and I haven't found a way to extract a useful segment from them without remuxing (and hiding the problem).

Revision history for this message
Sebastien Bacher (seb128) wrote :

what software do you use to play them? or do you use the gst-launch command line?

Revision history for this message
Forest (foresto) wrote :

I discovered the problem with Exaile, Totem, and Sound Converter. I verified it and narrowed it down with gst-launch.

Revision history for this message
Sebastien Bacher (seb128) wrote :

weird, totem is using gstreamer1.0 since trusty, it should be impacted by gst0.10 issues ... what version of Ubuntu are you using?

Revision history for this message
Forest (foresto) wrote :

When the problem showed up in Totem, I wasn't yet using trusty.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gst-plugins-good0.10 - 0.10.31-3+nmu1ubuntu6

---------------
gst-plugins-good0.10 (0.10.31-3+nmu1ubuntu6) vivid; urgency=medium

  * debian/patches/0010-flacparse-avoid-indefinite-search-for-frame-end.patch,
    debian/patches/0011-flacparse-additional-frame-crc-check.patch,
    debian/patches/0012-flacparse-additional-header-sanity-check.patch:
    - backport some bugfixes for flac, thanks "foresto" (lp: #1440440)
 -- Sebastien Bacher <email address hidden> Fri, 10 Apr 2015 16:04:03 +0200

Changed in gst-plugins-good0.10 (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Forest (foresto) wrote :

Thanks, Sebastien!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.