Don't use exit status 0 when rejecting login as root
Bug #1437350 reported by
Attila Fazekas
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| CirrOS |
Fix Released
|
Low
|
Scott Moser | ||
| cloud-init |
Won't Fix
|
Undecided
|
Dan Watkins | ||
Bug Description
$ ssh -i mykey root@10.1.0.2 ls
Warning: Permanently added '10.1.0.2' (RSA) to the list of known hosts.
Please login as 'cirros' user, not as root
$ echo $?
0
Since the command is not executed the exit status should be non 0.
/root/.
command="echo Please login as \'cirros\' user, not as root; echo; sleep 10" this part should be changed to:
"echo Please login as \'cirros\' user, not as root; echo; sleep 10; exit 1"
Related branches
lp:~oddbloke/cloud-init/lp-1437350
- Dan Watkins: Disapprove
- Joshua Harlow (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedcloudinit/config/cc_ssh.py (+1/-1)
| Changed in cirros: | |
| status: | New → In Progress |
| assignee: | nobody → Dr. Jens Rosenboom (j-rosenboom-j) |
Revision history for this message
| Attila Fazekas (afazekas) wrote | #1 |
| Changed in cloud-init: | |
| assignee: | nobody → Dan Watkins (daniel-thewatkins) |
| status: | New → In Progress |
| summary: |
- cirros uses exit status 0 when trying to login as root + Don't use exit status 0 when rejecting login as root |
Revision history for this message
| Dan Watkins (oddbloke) wrote | #2 |
| Changed in cloud-init: | |
| status: | In Progress → Invalid |
| status: | Invalid → Opinion |
| status: | Opinion → Invalid |
| Changed in cirros: | |
| importance: | Undecided → Low |
Revision history for this message
| Scott Moser (smoser) wrote | #3 |
| Changed in cloud-init: | |
| status: | Invalid → Won't Fix |
| Changed in cirros: | |
| assignee: | Dr. Jens Rosenboom (j-rosenboom-j) → Scott Moser (smoser) |
| status: | In Progress → Fix Committed |
Revision history for this message
| Dr. Jens Harbott (j-harbott) wrote | #4 |
| Changed in cirros: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| James Falcon (falcojr) wrote | #5 |
To post a comment you must log in.
Adding cloud-init as affacted project, because it also behavaes in this way.