Mir

[regression] "Playground" event filters get registered twice

Bug #1437174 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Alan Griffiths
Mir 0.13.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[regression] "Playground" event filters get registered twice. For each press I get two down events, and then on release two up events.

This was first observed as bug 1437166, which is easy to fix in itself. But the issue remains if an EventFilter fails to handle (return true) an event it now gets executed with that event twice.

This regression was introduced in:

------------------------------------------------------------
revno: 2429 [merge]
author: Alan Griffiths <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Thu 2015-03-26 15:04:21 +0000
message:
  shell: Provide a configuration point for the WindowManagement strategy.

  Approved by PS Jenkins bot, Andreas Pokorny, Alexandros Frantzis.
------------------------------------------------------------

See original description
Tags: regression

Related branches

lp:~alan-griffiths/mir/fix-1437174
Alexandros Frantzis (community): Approve
Kevin DuBois (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 50 lines (+19/-11)
2 files modified
playground/demo-shell/demo_shell.cpp (+8/-4)
playground/server_configuration.cpp (+11/-7)
lp:ubuntu/wily-proposed/mir
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

The cause is playground code registering event filters every time that the_composite_event_filter() is called. In the past this worked by happy accident. (Although as Daniel says this would be benign if the filter were to return true for handled events.)

Filters should only be added when the CompositeEventFilter is created.

Changed in mir:
assignee: nobody → Alan Griffiths (alan-griffiths)
Alan Griffiths (alan-griffiths)
description: updated
summary: - [regression] Event filters may be executed twice
+ [regression] "Playground" event filters get registered twice
Changed in mir:
status: Triaged → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.13.0

Changed in mir:
status: In Progress → Fix Committed
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.13.1+15.10.20150520-0ubuntu1

---------------
mir (0.13.1+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Cemil Azizoglu ]
  * New upstream release 0.13.1 (https://launchpad.net/mir/+milestone/0.13.1)
    - ABI summary: No ABI break. Servers and clients do not need rebuilding.
      . Mirclient ABI unchanged at 8
      . Mircommon ABI unchanged at 4
      . Mirplatform ABI unchanged at 7
      . Mirserver ABI unchanged at 31
    - Bug fixes:
      . Can't load app purchase UI without a U1 account (LP: #1450377)
      . Crash because uncaught exception in mir::events::add_touch (LP: #1437357)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 21:20:15 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.