fix patch build failure in trusty

Bug #1435353 reported by Matthias Klose
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
patch (Debian)
Fix Released
Unknown
patch (Ubuntu)
Fix Released
High
Unassigned
Trusty
Fix Released
High
Unassigned

Bug Description

seen in a test rebuild with a modified toolchain, and in a clean trusty environment

=====================================================
All 34 tests behaved as expected (1 expected failure)
=====================================================
make[5]: Leaving directory `/build/buildd/patch-2.7.1/tests'
make[4]: Leaving directory `/build/buildd/patch-2.7.1/tests'
make[3]: Leaving directory `/build/buildd/patch-2.7.1/tests'
make[3]: Entering directory `/build/buildd/patch-2.7.1'
make[3]: Leaving directory `/build/buildd/patch-2.7.1'
make[2]: Leaving directory `/build/buildd/patch-2.7.1'
make[1]: Leaving directory `/build/buildd/patch-2.7.1'
# make sure we call ed as "ed"
[ "$(strings -n 2 src/patch | grep -w 'ed$')" = "ed" ]
make: *** [build-stamp] Error 1
dpkg-buildpackage: error: debian/rules build gave error exit status 2

As pointed out in https://bugs.debian.org/729132, the ed strings is found more than once for some builds, so just check the config file for the name of ed.

The fix is already in current Ubuntu releases

To validate; Check that the package builds, and passes the tests.

Matthias Klose (doko)
Changed in patch (Ubuntu Trusty):
milestone: none → trusty-updates
status: New → Confirmed
Changed in patch (Ubuntu):
milestone: trusty-updates → none
status: Confirmed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Matthias, or anyone else affected,

Accepted patch into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/patch/2.7.1-4ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in patch (Ubuntu Trusty):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Matthias Klose (doko) wrote :

the package built successfully on all architectures. And it builds successfully with my proposed toolchain changes

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package patch - 2.7.1-4ubuntu2

---------------
patch (2.7.1-4ubuntu2) trusty-proposed; urgency=medium

  * Fix the check for ed to be more robust against compiler optimizations.
    Fixes the build failure seen in trusty-updates. LP: #1435353.
    See Debian #729132 for the proposed fix.
 -- Matthias Klose <email address hidden> Mon, 23 Mar 2015 15:22:31 +0100

Changed in patch (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for patch has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Mathew Hodson (mhodson)
Changed in patch (Ubuntu):
importance: Undecided → Critical
Changed in patch (Ubuntu Trusty):
importance: Undecided → Critical
Mathew Hodson (mhodson)
Changed in patch (Ubuntu):
importance: Critical → High
Changed in patch (Ubuntu Trusty):
importance: Critical → High
Changed in patch (Debian):
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.