existing /var/tmp/fatsam.test breaks the test suite

Bug #1433 reported by Christian Reis
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Andrew Bennetts

Bug Description

We're getting serious PQM downtime because of failures in the test suite caused by the fact that a fatsam.test directory already exists.

It may make sense to stop using a hardcoded directory and instead generate the name.

Revision history for this message
Stuart Bishop (stub) wrote :

We can't generate the name due to the mechanics of the config system (the path is read from the config file, not generated at runtime, and changing this would introduce a whole host of other issues such as how to tell the suprocess what it should be using, how to test that read-from-the-config file actually works when the test suites don't do that, etc.)

The LibrianTestSetup should nuke it if it exists.

Revision history for this message
Dafydd Harries (daf) wrote :

At a glance, this hasn't been fixed yet. Whose job is it?

Revision history for this message
Dafydd Harries (daf) wrote :

Stuart says it doesn't happen very often, which means that it's not a particularly high priority.

Changed in launchpad:
status: New → Accepted
Revision history for this message
Dafydd Harries (daf) wrote :

Plus, the fact that PQM now runs tests in a chroot should prevent it from happening altogether.

Revision history for this message
Brad Bollenbach (bradb) wrote :

I thought spiv said he'd look into this. spiv?

Steve Alexander (stevea)
Changed in launchpad:
assignee: nobody → spiv
Revision history for this message
Andrew Bennetts (spiv) wrote :

I believe this part of LibrarianTestSetup means this was already fixed:

    def setUpRoot(self):
        if os.path.isdir(self.root):
            shutil.rmtree(self.root)
        os.makedirs(self.root, 0700)

Changed in launchpad:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.