thermald crashed with signal 5 in main()

StacktraceTop:
 thd_dbus_server_proc (no_daemon=1) at src/main.cpp:321
 main (argc=1, argv=0x7fff83c14cc8) at src/main.cpp:460

Status changed to 'Confirmed' because the bug affects multiple users.

This is trapping in g_logv in the final call of g_private_set:

g_private_set (&g_log_depth, GUINT_TO_POINTER (depth));

however, curiously, we've already done calls to g_private_get and g_private_set just a few lines earlier in the same block of code. I wonder if the earlier calls in the same block of code works because it's locked by &g_messages_lock

I've reported this upstream: https://github.com/01org/thermal_daemon/issues/68

Is this still an issue with the latest version of thermald (1.4.3-2~15.04.1)?

Further investigation shows that this can no-longer reproduced with the latest thermald. However, this was an accidentally fixed by another issued (bug 1480892), and when that bug is fixed this issue re-occurs.

The root cause is that this error is triggered when an existing instance of thermald is detected by the lock file and it is reported using thd_log_fatal(). Instead, we should be reporting this with thd_log_error() and exiting via exit(EXIT_FAILURE) rather than going via the g_lib exit paths.

[SRU Justification] (Vivid, Trusty)

Thermald exiting because it is already running will abort via a thd_log_fatal message that triggers a SIGTRAP on a segmentation fault. This fix resolves this and thermald will exit cleanly with exit(EXIT_FAILURE) and a message without the SIGTRAP + segmentation fault.

[Test Case]
Check thermald is already running as a deamon. Next, start another instance of thermald from the command line:

sudo thermald --no-daemon --loglevel=info

Without the fix this can crash with a SIGTRAP on a segmentation fault. With the fix, thermald will report another instance of thermald is running and then cleaning exit with EXIT_FAILURE (1) exit status.

[Regression Potential]
Can't think of any, this is a one line fix that does not trip a segfault because the fix uses the correct way to log an error.

Hello Andreas, or anyone else affected,

Accepted thermald into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/1.4.3-3~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Andreas, or anyone else affected,

Accepted thermald into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/1.4.3-3~15.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Verified on trusty -proposed

Verified on vivid -proposed

This bug was fixed in the package thermald - 1.4.3-4

---------------
thermald (1.4.3-4) unstable; urgency=medium

  * Fix null pointer deferences with _ART active trip points (LP: #1480821)
  * Re-enable lockfile (LP:# 1480892)
  * Report multiple instances of thermald with thd_log_fatal (LP: #1432220)

 -- Colin King <email address hidden> Mon, 3 Aug 2015 18:47:00 +0100

This bug was fixed in the package thermald - 1.4.3-3~14.04.1

---------------
thermald (1.4.3-3~14.04.1) trusty; urgency=medium

  * Fix null pointer deferences with _ART active trip points (LP: #1480821)
  * Re-enable lockfile (LP: #1480892)
  * Report multiple instances of thermald with thd_log_fatal (LP: #1432220)
  * Suppress systemd failed service messages (e.g. on VMs) (LP: #1480182)

 -- Colin King <email address hidden> Tue, 4 Aug 2015 11:50:00 +0100

The verification of the Stable Release Update for thermald has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package thermald - 1.4.3-3~15.04.1

---------------
thermald (1.4.3-3~15.04.1) vivid; urgency=medium

  * Fix null pointer deferences with _ART active trip points (LP: #1480821)
  * Re-enable lockfile (LP: #1480892)
  * Report multiple instances of thermald with thd_log_fatal (LP: #1432220)
  * Suppress systemd failed service messages (e.g. on VMs) (LP: #1480182)

 -- Colin King <email address hidden> Tue, 4 Aug 2015 11:48:00 +0100

Hello Andreas, or anyone else affected,

Accepted thermald into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/1.7.0-5ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

The bionic SRU test message occurred because I accidentally uploaded the package with the entire old history. This bug has already been fixed and the verification for bionic can be ignored.