Thumbnails are returned one by one to QML thus already existing thumbnails can be blocked
Bug #1425043 reported by
Florian Boucault
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Thumbnailer |
Fix Released
|
High
|
Unassigned | ||
| qtdeclarative-opensource-src (Ubuntu) |
Fix Released
|
High
|
Timo Jyrinki | ||
| qtdeclarative-opensource-src (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Thumbnail requests made via the QML thumbnailer image provider are enqueued and processed one by one which has some nasty UX consequences:
1) if a thumbnail already exists it won't be returned immediately if other thumbnails are ahead in the queue
2) video thumbnails are much slower to be generated so if one is being generated, all other thumbnails are blocked until it finishes
This issue would be alleviated if not for https:/
But even with the Qt bug fixed, 1) would still be an important issue in many cases
Related branches
lp:~fboucault/thumbnailer/new_qml_api
- Michi Henning (community): Disapprove
- Florian Boucault (community): Needs Fixing
- Jussi Pakkanen (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Xavi Garcia (community): Needs Fixing
-
Diff: 777 lines (+631/-14)13 files modifieddebian/libthumbnailer0.symbols (+1/-0)
include/thumbnailer.h (+9/-0)
plugins/Ubuntu/Thumbnailer/CMakeLists.txt (+2/-0)
plugins/Ubuntu/Thumbnailer/plugin.cpp (+3/-0)
plugins/Ubuntu/Thumbnailer/qthumbnailer.cpp (+260/-0)
plugins/Ubuntu/Thumbnailer/qthumbnailer.h (+114/-0)
plugins/Ubuntu/Thumbnailer/thumbnailqueue.cpp (+45/-0)
plugins/Ubuntu/Thumbnailer/thumbnailqueue.h (+41/-0)
src/libthumbnailer.map (+1/-0)
src/thumbnailer.cpp (+33/-12)
tests/basic.cpp (+23/-0)
tests/qml/tst_image_provider.qml (+2/-2)
tests/qml/tst_thumbnailer.qml (+97/-0)
lp:~aacid/thumbnailer/asyncprovider
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Unity Team: Pending requested
-
Diff: 722 lines (+342/-167)13 files modifiedinclude/thumbnailer.h (+2/-0)
plugins/Ubuntu/Thumbnailer/albumartgenerator.cpp (+86/-40)
plugins/Ubuntu/Thumbnailer/albumartgenerator.h (+7/-5)
plugins/Ubuntu/Thumbnailer/artgeneratorcommon.cpp (+1/-2)
plugins/Ubuntu/Thumbnailer/artgeneratorcommon.h (+1/-1)
plugins/Ubuntu/Thumbnailer/artistartgenerator.cpp (+87/-40)
plugins/Ubuntu/Thumbnailer/artistartgenerator.h (+8/-3)
plugins/Ubuntu/Thumbnailer/plugin.cpp (+7/-3)
plugins/Ubuntu/Thumbnailer/plugin.h (+3/-0)
plugins/Ubuntu/Thumbnailer/thumbnailgenerator.cpp (+110/-66)
plugins/Ubuntu/Thumbnailer/thumbnailgenerator.h (+10/-7)
src/libthumbnailer.map (+1/-0)
src/thumbnailer.cpp (+19/-0)
| Changed in thumbnailer: | |
| importance: | Undecided → High |
| status: | New → Confirmed |
Revision history for this message
| Albert Astals Cid (aacid) wrote | #1 |
Revision history for this message
| Albert Astals Cid (aacid) wrote | #2 |
| Changed in qtdeclarative-opensource-src (Ubuntu): | |
| assignee: | nobody → Timo Jyrinki (timo-jyrinki) |
| status: | New → In Progress |
| importance: | Undecided → High |
Revision history for this message
| Timo Jyrinki (timo-jyrinki) wrote | #3 |
| Changed in qtdeclarative-opensource-src (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in qtdeclarative-opensource-src (Ubuntu RTM): | |
| status: | New → Fix Released |
| Changed in thumbnailer: | |
| status: | Confirmed → Fix Committed |
| Changed in thumbnailer: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Added my take on how to fix this using an un-merged Qt upstream patch