writable partitions not fsck'd.

Bug #1423529 reported by James Hunt
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Snappy
Fix Released
High
James Hunt

Bug Description

The writable partition, mounted in the initramfs, is not fsck'd. This has now been fixed in initramfs-tools-ubuntu-touch, but not in initramfs-tools-ubuntu-core.

Also, the fstab entry for the boot partition has the fsck field set to "0" when it should be "2".

James Hunt (jamesodhunt)
Changed in snappy-ubuntu:
assignee: nobody → James Hunt (jamesodhunt)
status: New → In Progress
importance: Undecided → High
Revision history for this message
James Hunt (jamesodhunt) wrote :

The reason for mounting the writable partition in the initramfs is to allow it to be move-mounted over the read-only root I believe, but stgraber may have more information on this.

Revision history for this message
Steve Langasek (vorlon) wrote :

The actual reason for mounting the writable partition read-write in the initramfs is that we have to bind-mount /writable/system-data/etc/systemd/system to /etc/systemd/system before systemd starts, which means we must be able to ensure that this source directory exists.

I don't think we should add even more code to the initramfs to accommodate this. I would rather we fix the userspace code to ensure the directory's existence, and in the worst case we should use systemctl daemon-reload.

Revision history for this message
James Hunt (jamesodhunt) wrote :

Ah - now it makes sense :-) So fwics, you added that code to handle the job that was previously done in writable-paths (ubuntu-core-config package). Handling the mount in writable-paths didn't work as it was mounted too late for systemd to see it at the point pid 1 started.

I believe pitti was looking at this too, so might have some thoughts on the best systemd approach on bringing the code back into userspace.

Meantime, I think it makes sense to land just the fsck_passno changes for the boot partition from my branch for now.

Revision history for this message
Steve Langasek (vorlon) wrote :

Looking more closely, I see that in fact all of the writable_paths handling happens in the initramfs. so this isn't specific to the systemd directory. It also means that removing any need for a read-write /writable in the initramfs requires a lot more work, and shouldn't block efforts to fix this problem.

I agree we should at least land the fix for fscking the boot partition. And fscking /writable from the initramfs is probably acceptable in the near term.

James Hunt (jamesodhunt)
Changed in snappy-ubuntu:
status: In Progress → Fix Released
Michael Terry (mterry)
affects: snappy-ubuntu → snappy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.