Missing API to wire in basic access authentication
Bug #1422339 reported by
Olivier Tilloy
This bug affects 9 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Oxide |
Fix Released
|
High
|
Ugo Riboni | ||
Bug Description
When trying to access a page that requires basic access authentication, the user gets a 401 (Unauthorized user). Oxide should expose an API on the WebView to allow embedders to display a dialog to request the user to input a username and a password (similar to the filePicker API).
Related branches
lp:~uriboni/oxide/basic-authentication
- Chris Coulson: Needs Fixing
- Olivier Tilloy (community): Needs Fixing
-
Diff: 1029 lines (+714/-5)23 files modifiedqt/core/api/oxideqhttpauthenticationrequest.cc (+103/-0)
qt/core/api/oxideqhttpauthenticationrequest.h (+64/-0)
qt/core/api/oxideqhttpauthenticationrequest_p.h (+47/-0)
qt/core/browser/oxide_qt_web_view.cc (+8/-0)
qt/core/browser/oxide_qt_web_view.h (+3/-0)
qt/core/core.gyp (+9/-0)
qt/core/glue/oxide_qt_web_view_proxy_client.h (+4/-0)
qt/qmlplugin/oxide_qml_plugin.cc (+5/-0)
qt/quick/api/oxideqquickwebview.cc (+26/-0)
qt/quick/api/oxideqquickwebview_p.h (+1/-0)
qt/quick/api/oxideqquickwebview_p_p.h (+2/-0)
qt/tests/qmltests/TestWebView.qml (+1/-1)
qt/tests/qmltests/api/tst_httpAuthentication.py (+31/-0)
qt/tests/qmltests/api/tst_httpAuthentication.qml (+142/-0)
shared/browser/oxide_resource_dispatcher_host_delegate.cc (+14/-3)
shared/browser/oxide_resource_dispatcher_host_delegate.h (+8/-0)
shared/browser/oxide_resource_dispatcher_host_login_delegate.cc (+162/-0)
shared/browser/oxide_resource_dispatcher_host_login_delegate.h (+65/-0)
shared/browser/oxide_web_view.cc (+6/-1)
shared/browser/oxide_web_view.h (+4/-0)
shared/browser/oxide_web_view_client.cc (+3/-0)
shared/browser/oxide_web_view_client.h (+4/-0)
shared/shared.gyp (+2/-0)
lp:~osomon/oxide/http-auth
- Chris Coulson: Approve
-
Diff: 1027 lines (+712/-5)23 files modifiedqt/core/api/oxideqhttpauthenticationrequest.cc (+105/-0)
qt/core/api/oxideqhttpauthenticationrequest.h (+62/-0)
qt/core/api/oxideqhttpauthenticationrequest_p.h (+50/-0)
qt/core/browser/oxide_qt_web_view.cc (+8/-0)
qt/core/browser/oxide_qt_web_view.h (+3/-0)
qt/core/core.gyp (+9/-0)
qt/core/glue/oxide_qt_web_view_proxy_client.h (+4/-0)
qt/qmlplugin/oxide_qml_plugin.cc (+4/-0)
qt/quick/api/oxideqquickwebview.cc (+26/-0)
qt/quick/api/oxideqquickwebview_p.h (+1/-0)
qt/quick/api/oxideqquickwebview_p_p.h (+2/-0)
qt/tests/qmltests/TestWebView.qml (+2/-1)
qt/tests/qmltests/api/tst_httpAuthentication.py (+31/-0)
qt/tests/qmltests/api/tst_httpAuthentication.qml (+145/-0)
shared/browser/oxide_resource_dispatcher_host_delegate.cc (+14/-3)
shared/browser/oxide_resource_dispatcher_host_delegate.h (+8/-0)
shared/browser/oxide_resource_dispatcher_host_login_delegate.cc (+156/-0)
shared/browser/oxide_resource_dispatcher_host_login_delegate.h (+63/-0)
shared/browser/oxide_web_view.cc (+6/-1)
shared/browser/oxide_web_view.h (+4/-0)
shared/browser/oxide_web_view_client.cc (+3/-0)
shared/browser/oxide_web_view_client.h (+4/-0)
shared/shared.gyp (+2/-0)
| Changed in oxide: | |
| milestone: | none → branch-1.8 |
| Changed in oxide: | |
| assignee: | nobody → Olivier Tilloy (osomon) |
| status: | New → Confirmed |
| Changed in oxide: | |
| assignee: | Olivier Tilloy (osomon) → Ugo Riboni (uriboni) |
| Changed in oxide: | |
| status: | Confirmed → In Progress |
| importance: | Undecided → High |
| Changed in oxide: | |
| milestone: | branch-1.8 → branch-1.9 |
| Changed in oxide: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
