TFTP into MAAS server from localhost causes unhandled error

Bug #1417591 reported by Christian Reis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Medium
Gavin Panella

Bug Description

1.7.1

tftp localhost
> get pxelinux.0

boom

2015-02-03 07:54:44-0600 [TFTP (UDP)] Datagram received from ('::1', 59260, 0, 0): <RRQDatagram(filename=pxelinux.0, mode=netascii)>
2015-02-03 07:54:44-0600 [TFTP (UDP)] Datagram received from ('::1', 59260, 0, 0): <RRQDatagram(filename=pxelinux.0, mode=netascii)>
2015-02-03 07:54:44-0600 [-] Unhandled error in Deferred:
2015-02-03 07:54:44-0600 [-] Unhandled Error
        Traceback (most recent call last):
          File "/usr/lib/python2.7/dist-packages/tftp/protocol.py", line 67, in _startSession
            context, self.backend.get_reader, datagram.filename)
          File "/usr/lib/python2.7/dist-packages/twisted/python/context.py", line 118, in callWithContext
            return self.currentContext().callWithContext(ctx, func, *args, **kw)
          File "/usr/lib/python2.7/dist-packages/twisted/python/context.py", line 81, in callWithContext
            return func(*args,**kw)
          File "/usr/lib/python2.7/dist-packages/provisioningserver/utils/twisted.py", line 62, in wrapper
            return maybeDeferred(func, *args, **kwargs)
        --- <exception caught here> ---
          File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 139, in maybeDeferred
            result = f(*args, **kw)
          File "/usr/lib/python2.7/dist-packages/provisioningserver/pserv_services/tftp.py", line 216, in get_reader
            mac_address = get_remote_mac()
          File "/usr/lib/python2.7/dist-packages/provisioningserver/boot/__init__.py", line 105, in get_remote_mac
            remote_host, remote_port = get("remote", (None, None))
        exceptions.ValueError: too many values to unpack

Related branches

Revision history for this message
Gavin Panella (allenap) wrote :

I can't reproduce this. Can you try logging the value at line 105 in provisioningserver/boot/__init__.py:

    log.msg("remote=%r" % (get("remote", "<not set>"),))

Gavin Panella (allenap)
Changed in maas:
status: New → Incomplete
Revision history for this message
Christian Reis (kiko) wrote :

Here you go; I guess that's not what you expected?

2015-02-03 10:33:49-0600 [-] remote=('::1', 50809, 0, 0)
2015-02-03 10:33:49-0600 [-] remote=('::1', 50809, 0, 0)
2015-02-03 10:33:49-0600 [-] Unhandled error in Deferred:
2015-02-03 10:33:49-0600 [-] Unhandled Error
        Traceback (most recent call last):
          File "/usr/lib/python2.7/dist-packages/tftp/protocol.py", line 67, in _startSession
            context, self.backend.get_reader, datagram.filename)
          File "/usr/lib/python2.7/dist-packages/twisted/python/context.py", line 118, in callWithContext
            return self.currentContext().callWithContext(ctx, func, *args, **kw)
          File "/usr/lib/python2.7/dist-packages/twisted/python/context.py", line 81, in callWithContext
            return func(*args,**kw)
          File "/usr/lib/python2.7/dist-packages/provisioningserver/utils/twisted.py", line 62, in wrapper
            return maybeDeferred(func, *args, **kwargs)
        --- <exception caught here> ---
          File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 139, in maybeDeferred
            result = f(*args, **kw)
          File "/usr/lib/python2.7/dist-packages/provisioningserver/pserv_services/tftp.py", line 216, in get_reader
            mac_address = get_remote_mac()
          File "/usr/lib/python2.7/dist-packages/provisioningserver/boot/__init__.py", line 108, in get_remote_mac
            remote_host, remote_port = get("remote", (None, None))
        exceptions.ValueError: too many values to unpack

Christian Reis (kiko)
Changed in maas:
milestone: none → next
status: Incomplete → Triaged
importance: Undecided → Medium
Gavin Panella (allenap)
Changed in maas:
assignee: nobody → Gavin Panella (allenap)
status: Triaged → In Progress
Gavin Panella (allenap)
Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
milestone: next → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.