open-vm-dkms fails to build with latest Precise kernel

Bug #1416003 reported by Luis Henriques
54
This bug affects 8 people
Affects Status Importance Assigned to Milestone
open-vm-tools (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
High
Luis Henriques

Bug Description

[Impact]
The open-vm-dkms package fails to build from source.

[Test Case]
Since this is a FTBFS, a successful build is enough to verify this.

[Fix]
Applying the same fix as in 946e51f2bf37, i.e., replacing the usage of d_alias member by d_u.d_alias.

After upstream commit 946e51f2bf37 ("move d_rcu from overlapping d_child to overlapping d_alias") came in with a 3.2 stable update, this package fails to build from source. This is because the 'd_alias' member of struct dentry has been moved into the 'd_u' union.

Luis Henriques (henrix)
Changed in openafs (Ubuntu):
importance: Undecided → High
Revision history for this message
Luis Henriques (henrix) wrote :

Attaching debdiff

Luis Henriques (henrix)
Changed in open-vm-tools (Ubuntu):
assignee: nobody → Luis Henriques (henrix)
status: New → In Progress
importance: Undecided → High
no longer affects: openafs (Ubuntu)
description: updated
tags: added: patch
Revision history for this message
Luis Henriques (henrix) wrote :

Here's v2 of the debdiff, now with a proper fix. I've also done some testing in a Precise VM.

Changed in open-vm-tools (Ubuntu Precise):
status: New → In Progress
assignee: nobody → Luis Henriques (henrix)
importance: Undecided → High
Revision history for this message
Chris J Arges (arges) wrote :

Uploaded for Precise. This does not affect any newer versions.

Changed in open-vm-tools (Ubuntu):
assignee: Luis Henriques (henrix) → nobody
status: In Progress → Fix Released
importance: High → Undecided
Revision history for this message
Stéphane Graber (stgraber) wrote : Please test proposed package

Hello Luis, or anyone else affected,

Accepted open-vm-tools into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/open-vm-tools/2011.12.20-562307-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in open-vm-tools (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Luis Henriques (henrix) wrote :

I've verified that the open-vm-tools currently in -updates (2011.12.20-562307-0ubuntu1) fails to build when installed with the latest precise kernel (3.2.0-76.111):

Error! Build of vmhgfs.ko failed for: 3.2.0-76-generic (x86_64)
Consult the make.log in the build directory
/var/lib/dkms/open-vm-tools/2011.12.20/build/ for more information.

(I can provide the make.log if required.)

The package currently in -proposed (2011.12.20-562307-0ubuntu1.1) installs and builds successfully. I'm tagging this bug as verified.

tags: added: verification-done
removed: verification-needed
Revision history for this message
David Andruczyk (david-andruczyk) wrote :

I have also verified this failure exists with open-vm-tools 2011.12.20-562307-0ubuntu1 against kernel 3.2.0-76.111 when my nodes failed to come up completely on VMware (waiting for network which depended on the vmxnet driver which wasn't there)

  CC [M] /var/lib/dkms/open-vm-tools/2011.12.20/build/vmhgfs/inode.o
/var/lib/dkms/open-vm-tools/2011.12.20/build/vmhgfs/inode.c: In function 'HgfsPermission':
/var/lib/dkms/open-vm-tools/2011.12.20/build/vmhgfs/inode.c:1821:19: error: 'struct dentry' has no member named 'd_ali
as'
/var/lib/dkms/open-vm-tools/2011.12.20/build/vmhgfs/inode.c:1821:19: warning: initialization from incompatible pointer
 type [enabled by default]
/var/lib/dkms/open-vm-tools/2011.12.20/build/vmhgfs/inode.c:1821:19: error: 'struct dentry' has no member named 'd_ali
as'
make[2]: *** [/var/lib/dkms/open-vm-tools/2011.12.20/build/vmhgfs/inode.o] Error 1
make[1]: *** [_module_/var/lib/dkms/open-vm-tools/2011.12.20/build/vmhgfs] Error 2
make[1]: Leaving directory `/usr/src/linux-headers-3.2.0-76-virtual'
make: *** [vmhgfs.ko] Error 2
make: Leaving directory `/var/lib/dkms/open-vm-tools/2011.12.20/build/vmhgfs'

Revision history for this message
David Andruczyk (david-andruczyk) wrote :

Installing open-vm-dkms/open-vm-tools (2011.12.20-562307-0ubuntu1.1) from precise-proposed has solved the compile issue for the 3.2.0-76.111 kernel.

Thanks!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package open-vm-tools - 2011.12.20-562307-0ubuntu1.1

---------------
open-vm-tools (2011.12.20-562307-0ubuntu1.1) precise; urgency=medium

  * Upstream v3.2.66 porting (LP: #1416003):
    - 'd_alias' member of struct dentry has been moved into the 'd_u' union
 -- Luis Henriques <email address hidden> Fri, 30 Jan 2015 08:25:20 -0600

Changed in open-vm-tools (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for open-vm-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.