Calculator should use MainView and Page instead of Headers
Bug #1413789 reported by
Bartosz Kosiorek
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Calculator App |
Fix Released
|
Medium
|
Riccardo Padovani | ||
Bug Description
Calculator should use MainView and Page instead of Headers.
Such implementation was made in old Calculator implementation.
Current Header implementation is causing following problems:
1. Unable to change Windows title for Windows mode. Currently is "com.ubuntu.
2. Displaying warning:
qml: WARNING: Header is an internal component of Ubuntu.Components andits API may change or be removed at any moment.Please use MainView and Page instead.
Related branches
lp:~rpadovani/ubuntu-calculator-app/bumpToolkit
- Jenkins Bot: Approve (continuous-integration)
- Bartosz Kosiorek: Needs Fixing
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 539 lines (+148/-100)16 files modifiedapp/engine/CalculationHistory.qml (+2/-2)
app/ubuntu-calculator-app.qml (+61/-64)
app/ui/CalcKeyboard.qml (+3/-3)
app/ui/FavouritePage.qml (+3/-3)
app/ui/KeyboardButton.qml (+3/-3)
app/ui/KeyboardPage.qml (+19/-2)
app/ui/LandscapeKeyboard.qml (+20/-2)
app/ui/PortraitKeyboard.qml (+19/-2)
app/ui/Screen.qml (+2/-2)
app/ui/ScrollableView.qml (+2/-2)
app/upstreamcomponents/EmptyState.qml (+2/-2)
app/upstreamcomponents/ListItemWithActions.qml (+3/-3)
app/upstreamcomponents/ListItemWithActionsCheckBox.qml (+3/-3)
app/upstreamcomponents/MultipleSelectionVisualModel.qml (+1/-1)
app/upstreamcomponents/PageWithBottomEdge.qml (+4/-5)
manifest.json.in (+1/-1)
Revision history for this message
| Riccardo Padovani (rpadovani) wrote | #1 |
| Changed in ubuntu-calculator-app: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Riccardo Padovani (rpadovani) |
Revision history for this message
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote | #2 |
| Changed in ubuntu-calculator-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-calculator-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We will fix that when Ubuntu.Components 1.3 will be released, there will be a property `head.visible` in each page