Hop dialog crashes when clicking remove without selecting row

Bug #1413359 reported by mackanzx
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Brewtarget
Fix Committed
Undecided
Unassigned

Bug Description

row() of the ModelIndex returns -1 if no row is selected.

Two problems:
* getHop takes an unsigned int
* getHop can return null, but HopDialog::removeHop does not nullcheck the result.

mackanzx (mackan-90)
Changed in brewtarget:
assignee: nobody → mackanzx (mackan-90)
Revision history for this message
mackanzx (mackan-90) wrote :

Merge request 113

mackanzx (mackan-90)
Changed in brewtarget:
assignee: mackanzx (mackan-90) → nobody
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.