pqm-submit does not check for uncommitted changes

Bug #141026 reported by Julian Edwards
2
Affects Status Importance Assigned to Milestone
Bazaar PQM Plugin
Fix Released
Medium
John A Meinel

Bug Description

When using pqm-submit, it checks that the public branch is up-to-date but it does not check that you have uncommitted changes in the local branch.

This is a worthwhile check so that you don't submit something other than you think you are.

Related branches

Revision history for this message
John A Meinel (jameinel) wrote :

Agreed that this would be nice. It would make it a bit slower (since it effectively has to do a 'bzr status'), but it is probably best to do.
I'll put something together.

Changed in bzr-pqm:
assignee: nobody → jameinel
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
John A Meinel (jameinel) wrote :

the 0.92 branch and trunk both now check that the WT is clean before it sends the pqm submission.

If people want, we could probably add an '--allow-unclean' to get back to the old behavior.

Changed in bzr-pqm:
status: Triaged → Fix Released
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Awesome, thanks.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.