Ubuntu
python-cinderclient package

[SRU] Wrong hint key in volume create function

Bug #1404110 reported by Felipe Reyes on 2014-12-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	python-cinderclient (Ubuntu)	Fix Released	Undecided	Unassigned
	Trusty	Fix Released	Undecided	Unassigned

Bug Description

[Impact]

Heat uses 'scheduler hints' to instruct the cloud that some resources need special treatment, for instance that two cinder volumes have to be created on different backends.

Without this patch, cinder client is broken and hints aren't properly formatted leaving without effect the hints sent.

[Test Case]

Use script test_scheduler_hints.py against cinder API v2, the request sent will contain "scheduler_hints": {"same_host": "SOME_ID"} while the service expects "OS-SCH-HNT:scheduler_hints": {"same_host": "SOME_ID"}

An example output can be found in the file test_scheduler_hints.log

[Regression Potential]

No regression expected. Currently the key is being discarded by the service and this patch just format it properly

[Other Info]

Please refer to upstream commit:
https://review.openstack.org/#/c/72059/5

Blueprint: Support Cinder scheduler hints
https://github.com/openstack/heat-specs/blob/master/specs/kilo/cinder-scheduler-hints.rst

Definition of the key:
https://github.com/openstack/cinder/blob/stable/icehouse/cinder/api/contrib/scheduler_hints.py#L31
https://github.com/openstack/cinder/blob/stable/icehouse/cinder/api/contrib/scheduler_hints.py#L54

Tags:

Related branches

lp:ubuntu/trusty-proposed/python-cinderclient

Revision history for this message

Felipe Reyes (freyes) wrote on 2014-12-19:

script to verify badly formatted request Edit (508 bytes, text/x-python)

tags:

added: cts

Revision history for this message

Felipe Reyes (freyes) wrote on 2014-12-19:

test_scheduler_hints.py output Edit (29.1 KiB, text/plain)

Felipe Reyes (freyes) on 2015-01-07

tags:

added: openstack

Revision history for this message

Martin Pitt (pitti) wrote on 2015-01-09:

This is fixed in vivid.

Changed in python-cinderclient (Ubuntu):
status:	New → Fix Released

Revision history for this message

Martin Pitt (pitti) wrote on 2015-01-09:

Uploaded to trusty SRU review queue. Unsubscribing sponsors now. Thanks!

Changed in python-cinderclient (Ubuntu Trusty):
status:	New → In Progress

Revision history for this message

Felipe Reyes (freyes) wrote on 2015-01-14:

lp_1404110_trusty.debdiff Edit (4.0 KiB, text/plain)

New version of the patch with the correct bug number in the debian/changelog.

Revision history for this message

Chris J Arges (arges) wrote on 2015-01-14:

Sponsored for Trusty.

Revision history for this message

Brian Murray (brian-murray) wrote on 2015-01-15: Please test proposed package

Hello Felipe, or anyone else affected,

Accepted python-cinderclient into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-cinderclient/1:1.0.8-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in python-cinderclient (Ubuntu Trusty):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Revision history for this message

Felipe Reyes (freyes) wrote on 2015-01-27:

test_scheduler_hints_from_proposed.log Edit (14.1 KiB, text/plain)

Hi,

The package from -proposed worked as expected creating volumes with scheduler_hints enabled.

Thanks,

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-01-28:

#10

This bug was fixed in the package python-cinderclient - 1:1.0.8-0ubuntu2

---------------
python-cinderclient (1:1.0.8-0ubuntu2) trusty; urgency=medium

* debian/patches/fix-hint-key-in-volume.patch: Wrong hint key in volume
create function (LP: #1404110)
-- Felipe Reyes <email address hidden> Wed, 14 Jan 2015 13:20:22 -0600

Changed in python-cinderclient (Ubuntu Trusty):
status:	Fix Committed → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2015-01-28: Update Released

#11

The verification of the Stable Release Update for python-cinderclient has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.