Inkscape

Crash with color widget used in procedural template (trunk, 0.91.x)

Bug #1402182 reported by su_v on 2014-12-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Inkscape	Fix Released	Medium	jazzynico	Inkscape 0.92 "0.92"

Bug Description

A procedural template which uses a color widget (<param type="color" … />) causes inkscape to crash as soon as the template is selected in the 'File > New > Templates...' dialog.

Steps to reproduce:
1) install attached custom extension
2) launch inkscape trunk or 0.91.x
3) open templates dialog (Ctrl+Alt+N)
4) select 'Color...' in the list of available templates
--> crash

Test the same extension as normal effect:
5) relaunch inkscape
6) run 'Extensions > Debug > Page Color...'
7) change the page color and opacity in either tab
--> works as expected (no crash).

Test the same procedural template without the color widget:
8) quit inkscape
9) comment out line 14 in 'empty_color.inx'
10) launch inkscape, repeat step 4
--> no crash, but no color widget for easy color selection either.

Reproduced with Inkscape 0.91+devel r13795 and 0.91pre3 r13685 on OS X 10.7.5

Test case (extension) attached:
- empty_color.py
- empty_color.inx (template, using the same script)
- page_color.inx (effect, using the same script)

Extension also available in my procedural templates playground:
<lp:~suv-lp/+junk/inkscape-procedural-templates>

See original description

Tags:

Related branches

lp:~inkscape.dev/inkscape/trunk

Revision history for this message

su_v (suv-lp) wrote on 2014-12-13:

empty_color.py Edit (3.5 KiB, text/plain)

Revision history for this message

su_v (suv-lp) wrote on 2014-12-13:

empty_color.inx Edit (1.5 KiB, text/plain)

Revision history for this message

su_v (suv-lp) wrote on 2014-12-13:

page_color.inx Edit (1.2 KiB, text/plain)

Revision history for this message

su_v (suv-lp) wrote on 2014-12-13:

1402182-bt-full-r13795-debug-osx-x11-64bit.txt Edit (31.3 KiB, text/plain)

Backtrace (Inkscape 0.91+devel r13795, debug build 64bit, GTK+/X11 2.24.25)

su_v (suv-lp) on 2014-12-13

description:

updated

Revision history for this message

jazzynico (jazzynico) wrote on 2015-06-29:

Reproduced on Windows XP, Inkscape trunk rev. 14221.

Changed in inkscape:
status:	New → Triaged

Revision history for this message

jazzynico (jazzynico) wrote on 2015-06-29:

1402182-TemplateColorCrash.diff Edit (539 bytes, text/plain)

Changed in inkscape:
assignee:	nobody → jazzynico (jazzynico)
importance:	Undecided → Medium
milestone:	none → 0.91.1
status:	Triaged → In Progress
milestone:	0.91.1 → 0.92

Revision history for this message

jazzynico (jazzynico) wrote on 2015-06-29:

Patch tested on Xubuntu 15.04 (64 bit) and Windows XP (32 bit) with Inkscape trunk rev. 14221.
No regression found with other extensions and filters that use the color widget.

Not sure if we should backport it to the 0.91.x branch (no color widget in the current templates).

Revision history for this message

jazzynico (jazzynico) wrote on 2015-06-30:

Fixed in the trunk, rev. 14223.

Changed in inkscape:
status:	In Progress → Fix Committed

Revision history for this message

su_v (suv-lp) wrote on 2015-06-30:

On 2015-06-29 17:49 (+0200), jazzynico wrote:
> Not sure if we should backport it to the 0.91.x branch (no color
> widget in the current templates).

Are there specific reason why not to backport? Any user of Inkscape 0.91.x can (or could) write and/or use a custom procedural template with color widget(s) …

On 2015-06-30 10:23 (+0200), jazzynico wrote:
> Fixed in the trunk, rev. 14223.

Fix confirmed with r14224 on OS X 10.7.5 - thanks a lot!

Revision history for this message

jazzynico (jazzynico) wrote on 2015-06-30:

#10

~suv> Any user of Inkscape 0.91.x can (or could) write and/or use a custom procedural template with color widget(s)

Yes, you're right. I just felt that since there's no official procedural template of that type it wasn't really useful.

tags:

added: backport-proposed

Revision history for this message

su_v (suv-lp) wrote on 2015-09-29:

#11