MAAS

Memory size changes to incorrect size when page is refreshed

Bug #1401349 reported by Jason Hobbs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Blake Rouse
1.7
Fix Released
High
Blake Rouse
MAAS 1.7.1

Bug Description

On 1.7.1~rc1+bzr3313-0ubuntu1~trusty1, my storage shows up as 4096 MB on my node detail page when I first load it. After the "check power state" button renders, it changes to 4 MB.

Related branches

lp:~blake-rouse/maas/fix-1401349
Jason Hobbs (community): Approve
Diff: 24 lines (+2/-2)
2 files modified
src/maasserver/templates/maasserver/node_view.html (+1/-1)
src/maasserver/views/tests/test_nodes.py (+1/-1)
lp:~blake-rouse/maas/fix-1401349-1.7
Blake Rouse (community): Approve
Diff: 24 lines (+2/-2)
2 files modified
src/maasserver/templates/maasserver/node_view.html (+1/-1)
src/maasserver/views/tests/test_nodes.py (+1/-1)
lp:ubuntu/vivid-proposed/maas
Revision history for this message
Raphaël Badin (rvb) wrote :

Are you sure this bug is trigged byt clicking on the "check power state" button? Isn't the periodic JS-based refresh of the page that's causing the problem?

Revision history for this message
Raphaël Badin (rvb) wrote :

I can re-create this but like I said above it has nothing to do with the "check power state" button, the problem comes from the JS-based refresh.

Changed in maas:
importance: Undecided → High
status: New → Triaged
tags: added: js ui
Revision history for this message
Raphaël Badin (rvb) wrote :

The bug is there because in src/maasserver/views/nodes.py:node_to_dict we use node.display_memory() (which returns the memory in GB) and in the node view we just display the memory with node.memory (i.e. the memory in MB).

Raphaël Badin (rvb)
summary: - Memory size changes to incorrect size when "Check power state" button
- finishes loading
+ Memory size changes to incorrect size when page is refreshed
Revision history for this message
Jason Hobbs (jason-hobbs) wrote : Re: [Bug 1401349] Re: Memory size changes to incorrect size when "Check power state" button finishes loading

Right - you don't have to click on the check power state button, but the
value changes at the same time the button shows up.

Jason

On 12/11/2014 02:28 AM, Raphaël Badin wrote:
> Are you sure this bug is trigged byt clicking on the "check power state"
> button? Isn't the periodic JS-based refresh of the page that's causing
> the problem?
>

Revision history for this message
Raphaël Badin (rvb) wrote :

On 12/11/2014 03:05 PM, Jason Hobbs wrote:
> Right - you don't have to click on the check power state button, but the
> value changes at the same time the button shows up.

Right, when the JS code kicks in :)

Blake Rouse (blake-rouse)
Changed in maas:
status: Triaged → Confirmed
status: Confirmed → In Progress
assignee: nobody → Blake Rouse (blake-rouse)
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Christian Reis (kiko)
Changed in maas:
milestone: none → next
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
Revision history for this message
Andres Rodriguez (andreserl) wrote :

This bug has been reported and fixed on upstream MAAS. However, provided that the bug was listed on the debian changelog, this appears as needing verification for pending SRU [1]. This bug did not affect current MAAS in Ubuntu, hence setting this to verification-done to unblock pending SRU.

[1]:http://people.canonical.com/~ubuntu-archive/pending-sru.html

tags: added: verification-done
Andres Rodriguez (andreserl)
Changed in maas:
milestone: next → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.