The landscape-client charm is failing automated testing
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| landscape-client-charm |
Fix Released
|
High
|
David Britton | ||
| landscape-client (Juju Charms Collection) |
Fix Released
|
High
|
David Britton | ||
Bug Description
According to the latest test results by charm http://
http://
The landscape-client charm is failing charm proof, make lint and 001_install.test.
charm proof output:
W: Metadata missing required field "tags"
W: config.yaml: option registration-key does not have the keys: default
W: config.yaml: option script-users does not have the keys: default
W: config.yaml: option autodiscover-
W: config.yaml: option server-autodiscover does not have the keys: default
W: config.yaml: option http-proxy does not have the keys: default
W: config.yaml: option include-
W: config.yaml: option account-name does not have the keys: default
W: config.yaml: option ping-url does not have the keys: default
W: config.yaml: option data-path does not have the keys: default
W: config.yaml: option log-dir does not have the keys: default
W: config.yaml: option autodiscover-
W: config.yaml: option url does not have the keys: default
W: config.yaml: option tags does not have the keys: default
W: config.yaml: option log-level does not have the keys: default
W: config.yaml: option https-proxy does not have the keys: default
W: config.yaml: option exchange-interval does not have the keys: default
W: config.yaml: option urgent-
W: config.yaml: option ping-interval does not have the keys: default
W: config.yaml: option ssl-public-key does not have the keys: default
make lint output:
bzr: ERROR: unknown command "ls-lint"
make: *** [lint] Error 3
001_install.test output
ERROR charm not found in "/var/lib/
This is a Canonical written charm and should be of high quality following all the best practices (including passing charm proof) so we can use it as an example to other charm authors.
Related branches
- Chad Smith: Approve
- Andreas Hasenack: Approve
-
Diff: 532 lines (+127/-238)15 files modified.bzrignore (+2/-0)
TESTING (+17/-5)
config.yaml (+16/-0)
hooks/ceph.py (+1/-1)
hooks/install.py (+0/-1)
metadata.yaml (+1/-0)
tests/00-setup (+10/-0)
tests/001_install.test (+0/-95)
tests/10-deploy-register.py (+53/-0)
tests/Makefile (+0/-8)
tests/bundles.yaml (+20/-0)
tests/lib/test-config.yaml (+0/-8)
tests/lib/test-helpers.sh (+0/-114)
tests/test.sh (+0/-6)
tests/test.yaml (+7/-0)
| Matt Bruzek (mbruzek) wrote | #1 |
| Adam Collard (adam-collard) wrote | #2 |
| José Antonio Rey (jose) wrote | #3 |
| Changed in landscape-client (Juju Charms Collection): | |
| status: | New → Triaged |
| Changed in landscape-client (Juju Charms Collection): | |
| status: | Triaged → In Progress |
| importance: | Undecided → High |
| Changed in landscape-client-charm: | |
| status: | New → Fix Committed |
| assignee: | nobody → David Britton (davidpbritton) |
| importance: | Undecided → High |
| Changed in landscape-client (Juju Charms Collection): | |
| status: | In Progress → Fix Released |
| Changed in landscape-client-charm: | |
| status: | Fix Committed → Fix Released |
Please note that you can add the default key to the configuration options in config yaml and that will reduce the warning to informational. The charm will still see these values as unset or null as before.